fix: curl proxy cse vars; e2e for noProxy #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeldeib
force-pushed
the
ace/proxy
branch
from
e4073e9 to
483a56e
Compare
alexeldeib
force-pushed
the
ace/proxy
branch
from
483a56e to
899b8c9
Compare
alexeldeib
force-pushed
the
ace/proxy
branch
from
1912531 to
cec5462
Compare
alexeldeib
commented
Feb 28, 2023
| @@ -141,7 +141,9 @@ | |||
| "ContainerdPackageURL": "", | |||
| "RuncPackageURL": "", | |||
| "FIPSEnabled": false, | |||
| "HTTPProxyConfig": null, | |||
| "HTTPProxyConfig": { | |||
There was a problem hiding this comment.
doesn't do anything but tests var syntax in bash
alexeldeib
commented
Feb 28, 2023
| @@ -76,6 +76,9 @@ if [[ "${SHOULD_CONFIGURE_CUSTOM_CA_TRUST}" == "true" ]]; then | |||
| fi | |||
|
|
|||
| if [[ -n "${OUTBOUND_COMMAND}" ]]; then | |||
| if [[ -n "${PROXY_VARS}" ]]; then | |||
| eval $PROXY_VARS | |||
There was a problem hiding this comment.
kinda annoying to form this export string properly without eval...
don't love eval, but pretty sure we sanitize this reasonably well in RP
and if we don't...congratulations, you're paying to hack your own VMs via shell script injection
anujmaheshwari1
approved these changes
Feb 28, 2023
alexeldeib
added a commit
that referenced
this pull request
Mar 3, 2023
alexeldeib
added a commit
that referenced
this pull request
Mar 3, 2023
alexeldeib
added a commit
that referenced
this pull request
Mar 3, 2023
alexeldeib
added a commit
that referenced
this pull request
Mar 3, 2023
alexeldeib
commented
Mar 7, 2023
| @@ -63,6 +63,9 @@ if [[ "${DISABLE_SSH}" == "true" ]]; then | |||
| disableSSH || exit $ERR_DISABLE_SSH | |||
| fi | |||
|
|
|||
| apt update && apt install -yq tinyproxy | |||
There was a problem hiding this comment.
this works but doesn't handle https serving endpoint for HTTPS_PROXY
you can set HTTPS_PROXY to http://url, but it's not testing full scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: