feat: multi input file support #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jtracey93
approved these changes
Oct 8, 2024
jaredfholgate
added a commit
to Azure/alz-terraform-accelerator
that referenced
this pull request
Oct 8, 2024
<!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary Replacing the complete-multi-region starter module with a modular implementation that leverages native Terraform inputs. Also adding ddos plan and other minor fixes / improvements. Please note that the `examples` folder and the `yaml.tf` file are deleted by the ALZ PowerShell module, so they do not get pushed to source control. The purpose of the `yaml.tf` file is to enable us to spit out a config YAML file that is used in the docs since we now use a tfvars files for the local testing. See the sister PR for those files: Azure/ALZ-PowerShell-Module#214 ## This PR fixes/adds/changes/removes N/A ### Breaking Changes This is a breaking change to the complete-multi-region starter module. ## Testing Evidence Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate). ## As part of this Pull Request I have - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/alz-terraform-accelerator/pulls) - [x] Associated it with relevant [issues](https://github.com/Azure/alz-terraform-accelerator/issues), for tracking and closure. - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/alz-terraform-accelerator/tree/main) - [x] Performed testing and provided evidence. - [x] Updated relevant and associated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Support for multiple input files that get merged together.
Docs updates for new version of complete-multi-region Terraform module.
Associated PR for starter module: Azure/alz-terraform-accelerator#175
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.