Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing private dns zones to applicable policy assignment and module #903

Merged
merged 22 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cb4a19e
Fix private dns zone list in policy assignment
oZakari Nov 13, 2024
fd6168e
Remove unused dns zone ids and update param names
oZakari Nov 15, 2024
bb50fc2
Remove unused dns zone ids and update param names
oZakari Nov 15, 2024
5bf3927
Merge branch 'fix-dns-policy-assignment' of https://github.com/oZakar…
oZakari Nov 15, 2024
b0b3006
Update generated docs
oZakari Nov 15, 2024
17e84f7
Add param to accelerator
oZakari Nov 15, 2024
ad2a1bb
Merge branch 'main' into fix-dns-policy-assignment
oZakari Nov 15, 2024
6d300fc
Generate Parameter Markdowns [oZakari/1618d0f4]
github-actions[bot] Nov 15, 2024
c806078
Fix value for param
oZakari Nov 15, 2024
1980ddd
Add prefix to dependabot title
oZakari Nov 18, 2024
7f25484
Merge branch 'main' into fix-dns-policy-assignment
oZakari Nov 27, 2024
e2b5b3f
Merge branch 'main' of https://github.com/Azure/ALZ-Bicep into fix-dn…
oZakari Nov 27, 2024
7bb229d
Merge branch 'fix-dns-policy-assignment' of https://github.com/oZakar…
oZakari Nov 27, 2024
64390a4
Update test values
oZakari Nov 27, 2024
0c52c91
Updated param table
oZakari Nov 27, 2024
7bedcf9
Generate Parameter Markdowns [oZakari/640a1dbc]
github-actions[bot] Dec 3, 2024
b71af3e
Update logic
oZakari Dec 4, 2024
a24b95e
Update spacing
oZakari Dec 4, 2024
8ffae7c
Merge branch 'main' into fix-dns-policy-assignment
oZakari Dec 4, 2024
83c232e
Add params to parameter file
oZakari Dec 4, 2024
92da18a
Merge branch 'fix-dns-policy-assignment' of https://github.com/Azure/…
oZakari Dec 4, 2024
c694569
Generate Parameter Markdowns [oZakari/0a582834]
github-actions[bot] Dec 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ updates:
labels:
- "Type: Hygiene :broom:"
- "Needs: Attention :wave:"
commit-message:
prefix: 'build: '

4 changes: 4 additions & 0 deletions accelerator/.config/ALZ-Powershell-Auto.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,10 @@
"Name": "parVirtualWanHubs.value[0].parHubLocation",
"Destination": "Parameters"
},
{
"Name": "parPrivateDnsZonesLocation.value",
"Destination": "Parameters"
},
{
"Name": "LOCATION",
"Destination": "Environment"
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ parMsDefenderForCloudEmailSecurityContact | No | Email address for Microso
parDdosEnabled | No | Enable/disable DDoS Network Protection. True enforces Enable-DDoS-VNET policy; false disables.
parDdosProtectionPlanId | No | Resource ID of the DDoS Protection Plan for Virtual Networks.
parPrivateDnsResourceGroupId | No | Resource ID of the Resource Group for Private DNS Zones. Empty to skip assigning the Deploy-Private-DNS-Zones policy.
parPrivateDnsZonesLocation | No | Location of Private DNS Zones.
parPrivateDnsZonesNamesToAuditInCorp | No | List of Private DNS Zones to audit under the Corp Management Group. This overwrites default values.
parDisableAlzDefaultPolicies | No | Disable all default ALZ policies.
parDisableSlzDefaultPolicies | No | Disable all default sovereign policies.
Expand Down Expand Up @@ -178,6 +179,12 @@ Resource ID of the DDoS Protection Plan for Virtual Networks.

Resource ID of the Resource Group for Private DNS Zones. Empty to skip assigning the Deploy-Private-DNS-Zones policy.

### parPrivateDnsZonesLocation

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)

Location of Private DNS Zones.

### parPrivateDnsZonesNamesToAuditInCorp

![Parameter Setting](https://img.shields.io/badge/parameter-optional-green?style=flat-square)
Expand Down Expand Up @@ -307,6 +314,9 @@ Opt out of deployment telemetry.
"parPrivateDnsResourceGroupId": {
"value": ""
},
"parPrivateDnsZonesLocation": {
"value": ""
},
"parPrivateDnsZonesNamesToAuditInCorp": {
"value": []
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@
"parPrivateDnsResourceGroupId": {
"value": "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/rg-alz-hub-networking-001"
},
"parPrivateDnsZonesLocation": {
"value": "eastus"
},
"parPrivateDnsZonesNamesToAuditInCorp": {
"value": []
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@
"value": "eastus"
},
"parLogAnalyticsWorkspaceResourceId": {
"value": "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/alz-logging/providers/Microsoft.OperationalInsights/workspaces/alz-log-analytics"
"value": "/subscriptions/69ac80fe-dbff-4971-9cba-9cb384486ba5/resourceGroups/alz-logging/providers/Microsoft.OperationalInsights/workspaces/alz-log-analytics"
},
"parDataCollectionRuleVMInsightsResourceId": {
"value": "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/alz-logging/providers/Microsoft.Insights/dataCollectionRules/alz-ama-vmi-dcr"
"value": "/subscriptions/69ac80fe-dbff-4971-9cba-9cb384486ba5/resourceGroups/alz-logging/providers/Microsoft.Insights/dataCollectionRules/alz-ama-vmi-dcr"
},
"parDataCollectionRuleChangeTrackingResourceId": {
"value": "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/alz-logging/providers/Microsoft.Insights/dataCollectionRules/alz-ama-ct-dcr"
"value": "/subscriptions/69ac80fe-dbff-4971-9cba-9cb384486ba5/resourceGroups/alz-logging/providers/Microsoft.Insights/dataCollectionRules/alz-ama-ct-dcr"
},
"parDataCollectionRuleMDFCSQLResourceId": {
"value": "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/alz-logging/providers/Microsoft.Insights/dataCollectionRules/ama-mdfcsql-default-dcr"
"value": "/subscriptions/69ac80fe-dbff-4971-9cba-9cb384486ba5/resourceGroups/alz-logging/providers/Microsoft.Insights/dataCollectionRules/ama-mdfcsql-default-dcr"
},
"parUserAssignedManagedIdentityResourceId": {
"value": "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourcegroups/alz-logging/providers/Microsoft.ManagedIdentity/userAssignedIdentities/alz-umi-identity"
"value": "/subscriptions/69ac80fe-dbff-4971-9cba-9cb384486ba5/resourcegroups/alz-logging/providers/Microsoft.ManagedIdentity/userAssignedIdentities/alz-umi-identity"
},
"parLogAnalyticsWorkspaceLogRetentionInDays": {
"value": "365"
Expand All @@ -37,6 +37,9 @@
},
"parTelemetryOptOut": {
"value": false
},
"parPrivateDnsZonesLocation": {
"value": "eastus"
}
}
}
Loading
Loading