Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API versions for Azure US Government #834

Closed
wants to merge 1 commit into from

Conversation

sshockley
Copy link

Overview/Summary

Azure US Government doesn't support the same API versions as Azure Commercial.

Related Issues/Work Items

Partially fixes #825

This PR fixes/adds/changes/removes

Updates API version with newest version supported in Azure US Government

Breaking Changes

N/A

Testing Evidence

I was able to configure policies in Azure US Government

As part of this Pull Request I have

@sshockley sshockley marked this pull request as ready for review August 28, 2024 15:09
@oZakari
Copy link
Contributor

oZakari commented Aug 30, 2024

Thanks for the PR @sshockley. Unfortunately, we will need to get another route as the API version for sentinel onboarding is not available in commercial cloud and we'll want to try and stick with the latest versions available in most cases for each cloud. We'll need to add a condition so that the resources that need specific gov API versions won't be deployed if for example a parameter called azuregov = true or something along those lines. Let me know if that makes sense.

@oZakari oZakari self-assigned this Aug 30, 2024
@oZakari oZakari added the Area: Sovereign 👽 GH issues raised for sovereign clouds (US Gov, China) label Aug 30, 2024
@oZakari
Copy link
Contributor

oZakari commented Sep 18, 2024

Closing this for now, but feel free to re-open if you would like to discuss further or if you would like to add the conditions I referred to above.

@oZakari oZakari closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Sovereign 👽 GH issues raised for sovereign clouds (US Gov, China)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying to GCC-H fails due to API version
2 participants