Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metric Alerts to Kubernetes cluster #68

Merged
merged 8 commits into from
Oct 5, 2021
Merged

Add Metric Alerts to Kubernetes cluster #68

merged 8 commits into from
Oct 5, 2021

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Oct 4, 2021

  • Create and reference Metric Alerts module with 2 parameters (enabled/frequency model), based on the secure baseline.
  • Ascii Art to better divide main.bicep
  • More Parameter metadata in main.bicep
  • Role assignment naming consistency
  • MonitoringMetricsPublisherRole used for Fast Alerting in bicep (save's enabling it afterwards)
  • AKS Diagnostics settings taken from secure baseline

Gordon Byers and others added 6 commits October 4, 2021 19:30
Adding metric alerts to AKS bicep (#66)
24726c0 
Metric Alerts
Ascii Art
More Parameter metadata
Role assignment naming consistency
MonitoringMetricsPublisherRole used for Fast Alerting in bicep.
Added Firewall mode param
c4386c5
Adding auto compiled bicep json
0dc2763
auto mitigation disabled
6aa8bb2
Adding auto compiled bicep json
eed688d
added pre-release flag to PSRule
b6297b0
@Gordonby Gordonby added the secure-baseline Relates to Secure Baseline Architecture label Oct 4, 2021
@Gordonby Gordonby requested a review from khowling October 4, 2021 20:25
@Gordonby Gordonby linked an issue Oct 4, 2021 that may be closed by this pull request
Bring in MetricAlerts to bicep #69
Closed
@Gordonby Gordonby temporarily deployed to azurecirgs October 5, 2021 08:14 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs October 5, 2021 13:56 Inactive
@Gordonby Gordonby merged commit 03a81a1 into main Oct 5, 2021
@Gordonby Gordonby deleted the develop branch October 5, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees
No one assigned
Labels
secure-baseline Relates to Secure Baseline Architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring in MetricAlerts to bicep
2 participants
@Gordonby @khowling