Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upping the lychee-action GitHub Action version number #636

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

oliverlabs
Copy link
Contributor

upping the lychee-action version number

PR Summary

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

upping the lychee-action version number
@oliverlabs oliverlabs changed the title Update ghpagesTest.yml upping the lychee-action GitHub Action version number Aug 10, 2023
@Gordonby
Copy link
Collaborator

Can you give some context around why @oliverlabs ?
Does it solve a problem?
Is this version stable, have you tested?

@Gordonby Gordonby added the enhancement New feature or request label Aug 17, 2023
@oliverlabs
Copy link
Contributor Author

@Gordonby, the html broken link checker action was failing ever since it was implemented. We were trying to troubleshoot it with @pjlewisuk. I think he found a workaround by creating a .lycheeignore file, but as part of the process, I also upped the version to the latest stable.

@pjlewisuk
Copy link
Contributor

pjlewisuk commented Aug 18, 2023

Specifically, we were seeing the broken link checker failing on https://shell.azure.com, it looks like this is because that UTL redirects to a login page which the link checker sees as a failure. I added shell.azure.com to an ignore list to prevent the error.

@Gordonby
Copy link
Collaborator

The broken link checker did work when implemented, and the focus is that of 3rd party sites such as the Azure Docs, the Kubernetes docs, etc.

Sounds like the ignore file is probably the right approach for the Azure Shell

@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Sep 18, 2023
@oliverlabs
Copy link
Contributor Author

no updates? @pjlewisuk can you approve?

@github-actions github-actions bot added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Sep 25, 2023
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@pjlewisuk pjlewisuk merged commit 6e6e103 into Azure:main Sep 25, 2023
5 checks passed
@oliverlabs oliverlabs deleted the omg-html-lychee-up branch September 26, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Keep Open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants