Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL security scanning & What-If reliability flag #158

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Dec 13, 2021

PR Summary

Adding code scanning

Discover vulnerabilities across a codebase with CodeQL
https://codeql.github.com/

Azure CLI What-If reliability

Leveraging a repo level secret variable, to continue on error for the What-If step (see comment).
Having it at the Repo level will let us more easily toggle it, and since this isn't the first time is halted builds - we need to do it easily.

ERROR: InternalServerError - Encountered internal server error while processing the deployment what-if request.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby self-assigned this Dec 13, 2021
@Gordonby Gordonby requested a review from a team December 13, 2021 09:27
@Gordonby Gordonby temporarily deployed to azurecirgs December 14, 2021 12:15 Inactive
@Gordonby
Copy link
Collaborator Author

Gordonby commented Dec 14, 2021

I've added this to 2 of the actions because What-If steps are failing with an "internal server error" on AZ CLI 2.30.0 and 2.31.0

        continue-on-error: ${{ secrets.ISAZCLIWHATIFUNRELIABLE == 'true' }}

ref: Azure/azure-cli#19850

@Gordonby Gordonby changed the title Add CodeQL security scanning Add CodeQL security scanning & What-If reliability flag Dec 14, 2021
@Gordonby Gordonby linked an issue Dec 14, 2021 that may be closed by this pull request
Copy link
Contributor

@JimPaine JimPaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would probably have liked the idea of handling the error differently :D but looking through the referenced issue a fix is on the way so this is great.

@Gordonby Gordonby merged commit 3b52516 into main Dec 15, 2021
@Gordonby Gordonby deleted the gb-codeql branch December 15, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub CodeQL
2 participants