Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing file to account-service #5

Merged

Conversation

julioalex-rezende
Copy link
Contributor

@julioalex-rezende julioalex-rezende commented Nov 3, 2023

Fixes #1

Purpose

  • Adding missing file in account-service, which was causing a build error during service deployment
  • updated aks version used in azd
  • included some checks on local deploy files to check existence before continuing, and interrupting in case of errors
  • ...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code
# local deployment
make run-local
make port-forward-local
make test-local

#azure deployment
azd up
make test-azure

What to Check

Local and Azure Deployments complete without errors.
make test-local and make test-azure return ACCEPTED response

@julioalex-rezende julioalex-rezende marked this pull request as ready for review November 10, 2023 09:57
@macromania
Copy link
Collaborator

Thank you @julioalex-rezende for this fix. 👏🏼

@macromania macromania merged commit 4afc376 into Azure-Samples:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run ./gradlew build fail
2 participants