Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation and sample app for msal go #22

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AndyOHart
Copy link

Purpose

Adds documentation and a sample application for MSAL GO

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x] Documentation content changes
[ ] Other... Please describe:

@AndyOHart AndyOHart marked this pull request as draft October 24, 2024 14:17
src/go/readme.md Outdated Show resolved Hide resolved
Click ont the version you would like to use
Copy the part after the key vault URI and use that as your secret name

## Publish your function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the app service is not implemented, will it be relevant to have a sample for the functions? Can we have a sample for VM instead since that is implemented?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked this as a draft PR so its ready to go when App Service is implemented. The other docs in this sample project are using AppService so I think we want to keep this the same, and then the other PR that is open is more about using the library

@localden
Copy link
Contributor

localden commented Dec 5, 2024

@AndyOHart any updates on this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants