Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkin distributables, generate docs #78

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Checkin distributables, generate docs #78

merged 1 commit into from
Jun 25, 2023

Conversation

derisen
Copy link
Contributor

@derisen derisen commented Jun 25, 2023

Pull Request

Purpose

  • Checkin distributables,
  • Generate docs

Does this introduce a breaking change

    [ ] Yes
    [ x ] No

Pull request type

What kind of change does this Pull Request introduce?

    [ ] Bugfix
    [ ] Feature
    [ ] Code style update (formatting, local variables)
    [ x ] Documentation content changes
    [ x ] Other... Please describe:

How to test

  • Get the code
    git clone [repo-address]
    cd [repo-name]
    git checkout [branch-name]
    npm install

What to check

ex: verify that the following are valid:

  • ...

Other Information

@derisen derisen merged commit 2f9240b into main Jun 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 25, 2023
View reviewed changes
Common/msal-node-wrapper/dist/middleware/authenticateMiddleware.esm.js
Comment on lines +32 to +40
appRouter.get(UrlUtils.getPathFromUrl(this.webAppAuthConfig.auth.frontChannelLogoutUri), (req, res, next) => {
if (req.authContext.isAuthenticated()) {
return req.authContext.logout({
postLogoutRedirectUri: "/",
idpLogout: false
})(req, res, next);
}
return res.status(401).send("Unauthorized");
});

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Common/msal-node-wrapper/dist/middleware/authenticateMiddleware.esm.js
Comment on lines +43 to +51
appRouter.use((req, res, next) => {
if (!req.authContext.isAuthenticated()) {
return req.authContext.login({
postLoginRedirectUri: req.originalUrl,
scopes: [],
})(req, res, next);
}
return next();
});

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited. This route handler performs [authorization](2), but is not rate-limited.
Common/msal-node-wrapper/dist/middleware/authenticateMiddleware.js
Comment on lines +34 to +42
appRouter.get(UrlUtils.UrlUtils.getPathFromUrl(this.webAppAuthConfig.auth.frontChannelLogoutUri), (req, res, next) => {
if (req.authContext.isAuthenticated()) {
return req.authContext.logout({
postLogoutRedirectUri: "/",
idpLogout: false
})(req, res, next);
}
return res.status(401).send("Unauthorized");
});

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Common/msal-node-wrapper/dist/middleware/authenticateMiddleware.js
Comment on lines +45 to +53
appRouter.use((req, res, next) => {
if (!req.authContext.isAuthenticated()) {
return req.authContext.login({
postLoginRedirectUri: req.originalUrl,
scopes: [],
})(req, res, next);
}
return next();
});

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited. This route handler performs [authorization](2), but is not rate-limited.
Common/msal-node-wrapper/dist/config/ConfigurationHelper.esm.js
* @returns
*/
static isB2CAuthority(authority) {
return authority.includes("b2clogin.com/");

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[b2clogin.com/](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Common/msal-node-wrapper/dist/config/ConfigurationHelper.js
* @returns
*/
static isB2CAuthority(authority) {
return authority.includes("b2clogin.com/");

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization

'[b2clogin.com/](1)' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derisen