Skip to content

Commit

Permalink
Add missing TypeDefinitionId to two nodes (#398)
Browse files Browse the repository at this point in the history
* Fix NumberOfUpdates type def

* Update version

* Update nugets

* Remove deprecated veryfast1kb plugin
  • Loading branch information
luiscantero authored Oct 17, 2024
1 parent 71b7f0c commit 656fadf
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 157 deletions.
8 changes: 0 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -606,14 +606,6 @@ Options:
--nf, --nodesfile=VALUE
the filename that contains the list of nodes to be
created in the OPC UA address space.
--vf1k, --veryfast1knodes=VALUE
number of very fast 1 kB nodes (Deprecated: Use
veryfastbsnodes).
Default: 1
--vf1kr, --veryfast1krate=VALUE
rate in ms to change very fast 1 kB nodes (
Deprecated: Use veryfastbsrate).
Default: 1000
--vfbs, --veryfastbsnodes=VALUE
number of very fast ByteString nodes.
Default: 1
Expand Down
1 change: 1 addition & 0 deletions src/PluginNodes/SlowFastCommon.cs
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ private BaseDataVariableState CreateNumberOfUpdatesVariable(string baseName, Fol
variable.BrowseName = name;
variable.DisplayName = name;
variable.Description = new LocalizedText("The number of times to update the {name} nodes. Set to -1 to update indefinitely.");
variable.TypeDefinitionId = VariableTypeIds.BaseDataVariableType;
simulatorFolder.AddChild(variable);

return variable;
Expand Down
141 changes: 0 additions & 141 deletions src/PluginNodes/VeryFast1KBPluginNodes.cs

This file was deleted.

4 changes: 2 additions & 2 deletions src/opc-plc.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<ItemGroup>
<FrameworkReference Include="Microsoft.AspNetCore.App" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.1" />
<PackageReference Include="Mono.Options" Version="6.12.0.148" />
<PackageReference Include="OpenTelemetry" Version="1.9.0" />
<PackageReference Include="OpenTelemetry.Api" Version="1.9.0" />
Expand All @@ -36,7 +36,7 @@
<PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.9.0" />
<PackageReference Include="Serilog.Extensions.Logging.File" Version="3.0.0" />
<PackageReference Update="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageReference Update="Nerdbank.GitVersioning" Version="3.6.141" />
<PackageReference Update="Nerdbank.GitVersioning" Version="3.6.143" />
</ItemGroup>

<!-- When referencing a local build of the OPC UA stack for testing, define the constant UseLocalOpcUaSdk in the file Directory.Build.targets -->
Expand Down
10 changes: 5 additions & 5 deletions tests/opc-plc-tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Bogus" Version="35.6.0" />
<PackageReference Include="FluentAssertions" Version="6.12.0" />
<PackageReference Include="Moq" Version="4.20.70" />
<PackageReference Include="NUnit" Version="4.1.0" />
<PackageReference Include="Bogus" Version="35.6.1" />
<PackageReference Include="FluentAssertions" Version="6.12.1" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="NUnit" Version="4.2.2" />
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
</ItemGroup>

<Choose>
Expand Down
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "2.12.24",
"version": "2.12.25",
"versionHeightOffset": -1,
"publicReleaseRefSpec": [
"^refs/heads/main$",
Expand Down

0 comments on commit 656fadf

Please sign in to comment.