-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDS fabric git integration sample #257
base: main
Are you sure you want to change the base?
Conversation
README.md
Outdated
@@ -86,6 +86,12 @@ This project provides samples outlining example implementations of various use c | |||
|------|-----------| | |||
|[MedTech service mappings](/samples/medtech-service-mappings/)|The [MedTech service](https://learn.microsoft.com/azure/healthcare-apis/iot/overview) scenario-based samples provide conforming and valid [device](https://learn.microsoft.com/azure/healthcare-apis/iot/overview-of-device-mapping) and [FHIR destination](https://learn.microsoft.com/azure/healthcare-apis/iot/overview-of-fhir-destination-mapping) mappings and test device messages to assist with authoring and troubleshooting mappings.| | |||
|
|||
### Healthcare data solutions on Fabric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Healthcare data solutions in Microsoft Fabric
@@ -0,0 +1,21 @@ | |||
# Microsoft Fabric Healthcare Data Solutions Git Integration Helper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Healthcare data solutions in Microsoft Fabric ALM Helper"
Since it's not just for git it's also deployment pipelines.
README.md
Outdated
|
||
|Sample|Description| | ||
|------|-----------| | ||
|[Git integration helper](/samples/fabric-healthcare-data-solutions/sample-notebooks/git_integration_helper.ipynb)|[Healthcare Data Solutions (HDS)](https://learn.microsoft.com/en-us/industry/healthcare/healthcare-data-solutions/overview) in [Microsoft Fabric](https://learn.microsoft.com/en-us/fabric/get-started/microsoft-fabric-overview) supports version control through [Application Lifecycle Management (ALM)](https://learn.microsoft.com/en-us/fabric/cicd/git-integration/intro-to-git-integration?tabs=azure-devops). This sample notebook allows for seemless migration of a Healthcare data solution item that is checked into version control to be migrated into another Fabric workspace.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ALM helper" instead of "Git integration helper"
It's also not doing anything with version control right? It's pulling from a "source workspace" so could say "This sample notebook allows for seamless migration of the Healthcare data solution item dependencies from a source workspace." ?
|
||
## Overview | ||
|
||
Healthcare data solutions in Microsoft Fabric help you accelerate time to value by addressing the critical need to efficiently transform healthcare data into a suitable format for analysis. With these solutions, you can conduct exploratory analysis, run large-scale analytics, and power generative AI with your healthcare data. More information about Healthcare data solutions on Fabric can be found [here](https://learn.microsoft.com/en-us/industry/healthcare/healthcare-data-solutions/overview). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Healthcare data solutions in Microsoft Fabric"
|
||
This sample provides a notebook for customers who have already deployed their Healthcare data solutions item in Fabric and want to take advantage of Application Lifecycle Management (ALM). ALM allows developers who are developing in Fabric to apply the capabilities of familiar source control tools to manage Fabric items. | ||
|
||
There are some additional, manual steps to be able to run Helathcare data solutions capabilities after syncing a workspace with ALM. The `git_integration_helper` attempts to streamline these manual steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call it "hds_alm_helper"?
|
||
## Prerequisites | ||
|
||
For this sample, it is assumed that you have already deployed an instance of Healthcare data solutions and one or more capabilities following [these steps](https://learn.microsoft.com/en-us/industry/healthcare/healthcare-data-solutions/deploy?toc=%2Findustry%2Fhealthcare%2Ftoc.json&bc=%2Findustry%2Fbreadcrumb%2Ftoc.json). It is also assumed that you have connected your Workspace to Git and commited those changes to a branch following [these steps](https://learn.microsoft.com/en-us/fabric/cicd/git-integration/git-get-started?tabs=azure-devops%2CAzure%2Ccommit-to-git). Now, you want to create a new workspace and synchronize your Healthcare data solutions item. After creating the workspace, connecting to the branch (following the same steps detailed above), and waiting for your Fabric items to sync (see branch steps above), you are ready to run the sample notebook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually require git integration correct? If a customer uses deployment pipelines on their own there is no git dependency. So we could say "It is also assumed that you have connected your Workspace to Git and/or are using deployment pipelines to move the Healthcare data solution item to down stream workspaces. Now, you want to create a new workspace and synchronize your Healthcare data solution item dependencies. After creating the target workspace and connecting to the git repo or using a deployment pipeline, you are ready to run the sample notebook."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, I don't think it's a bad idea to say you expect they've connected to git as I'd think that's the preferred approach vs. someone only using deployment pipelines, but it should be worded in a way where git isn't required for downstream/target workspaces. So we could say "It is also assumed that you have connected your Workspace to Git and committed those changes to a branch following 'these steps'. Now, you want to create a new workspace and synchronize your Healthcare data solution item dependencies. After creating the target workspace and connecting to the git repo or using a deployment pipeline (see here https://learn.microsoft.com/en-us/fabric/cicd/manage-deployment), you are ready to run the sample notebook."
|
||
## What does the sample notebook do? | ||
|
||
The `git_integration_helper` notebook helps copy important system configuration files, creates folders and tables, and updates metadata of other Fabric items in your workspace. This saves an immense amount of time and allows you to quickly start managing your healthcare data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hds_alm_helper"
|
||
## How do I get started? | ||
|
||
If you meet the criteria defined in the scenario overview above, all you need to do to run the `git_integration_helper` notebook is import it into the **_source_** Fabric workspace, open the notebook, and run through the cells. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hds_alm_helper"
|
||
## How do I get started? | ||
|
||
If you meet the criteria defined in the scenario overview above, all you need to do to run the `git_integration_helper` notebook is import it into the **_source_** Fabric workspace, open the notebook, and run through the cells. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"target" workspace not "source" correct?
@@ -0,0 +1,586 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the latest notebook? It's different than what was used in the bugbash.
@microsoft-github-policy-service agree company="Microsoft" |
" source_table_path = f\"{source_tables_path}/{table_name}\"\n", | ||
" dest_table_path = f\"{dest_tables_path}/{table_name}\"\n", | ||
" \n", | ||
" spark.sql(f'CREATE TABLE delta.`{dest_table_path}` SHALLOW CLONE delta.`{source_table_path}`')\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do CREATE TABLE IF NOT EXISTS
to avoid errors if the table was already copied?
"\n", | ||
" return updated_global_parameters, replacements\n", | ||
"\n", | ||
"def get_updated_activties_configuration(source_workspace_id: str, source_admin_lakehouse_id: str, dest_workspace_id: str, dest_admin_lakehouse_id: str) -> Any:\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo get_updated_activities_configuration
"id": "f5e8672d", | ||
"metadata": {}, | ||
"source": [ | ||
"#### Copy System Data\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wrap these function calls in flags and set the flags at the top of the notebook all to true? Make it easy for the customer to run a subset or skip certain steps on subsequent runs?
Adding a git integration migration sample for Healthcare data solutions for Fabric.