Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resource requests and limits to yaml #34

Merged
merged 1 commit into from
Jul 5, 2023
Merged

feat: add resource requests and limits to yaml #34

merged 1 commit into from
Jul 5, 2023

Conversation

pauldotyu
Copy link
Contributor

Purpose

  • Add resource requests and limits to deployment manifests

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@chzbrgr71
Copy link
Collaborator

Looks right to me

chzbrgr71
chzbrgr71 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@chzbrgr71 chzbrgr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chzbrgr71 chzbrgr71 merged commit 1755783 into main Jul 5, 2023
4 checks passed
@pauldotyu pauldotyu deleted the yaml-updates branch July 17, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chzbrgr71 chzbrgr71 chzbrgr71 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldotyu @chzbrgr71