This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
Checking if getting items from the POIStore results in exception #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - VJ reviewed this change. Note that this change was made specifically for the POI Store since this is where the SQLite call was failing in the stack trace. There is a likelihood that this same failure will now occur later in the app - this change will help determine if this theory is true or not. Going ahead and checking in based on offline conversation with VJ. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the crash in issue #496 - so far this crash seems to occur when getting items from the POI Store. We are currently unsure why a SQLite exception would be thrown at this point, so this call is now wrapped in a try\catch block to at least prevent the crash from occurring.