-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: goodbye noir-starter, hello noirenberg #89
Conversation
… noir and barretenberg versions
✅ Deploy Preview for noir-vite-hardhat canceled.
|
btw since this repo doesn't use |
import axios from 'axios'; | ||
|
||
export async function getBbVersion(noirVersion: string) { | ||
const url = `https://raw.githubusercontent.com/noir-lang/noir/v${noirVersion}/scripts/install_bb.sh`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging that I'm not sure if / when @TomAFrench might plan to deprecate this script from Noir, which could break this noirenberg script here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how there is no good way to source Noir compatibility from within Barretenberg yet, don't think this should be blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, this script is purely an implementation detail of the noir repo CI and we don't provide any guarantees about its stability.
Note that hosting the noirenberg installation script in a standalone AztecProtocol repo (instead of as a part of the starter / boilerplate repo) might make more sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool tool! I think you need to update the README as well.
Do you publish updates to noirenberg
directly from this repo? Is this repo the best home for this tool? It feels unrelated to a Noir stater repo, and not something that I'd necessarily want to clone when starting a noir project.
871da21
to
70de136
Compare
Problem
Noir and BB versions were hard to sync. After some discussion, we agreed that there could be a tool to check the correct
bb
version for the wantednoir
version.As it wouldn't live inside the
noir
repository or even inside thenoir-lang
org (check #88), we thought it could have a creative name.Description
Starts a refactor by extending the existent
npx
script to do this installation and check. It also moves it tots
using the excellentbun
andtsx
tooling.I reckon I went a bit overboard with the dependencies on
ora
but I also wanted it to look good!Next steps
nargo
andbb
that we have already identified and agreed. But I'll spike those and discuss internally first