Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example code of recursive proof #207

Merged
merged 18 commits into from
Apr 17, 2024
Merged

example code of recursive proof #207

merged 18 commits into from
Apr 17, 2024

Conversation

jzaki
Copy link
Contributor

@jzaki jzaki commented Apr 9, 2024

pure ts module to show recursive proof. Intended to use export+codegen via scripts, but execution doesn't verify inner proofs. A future pr will extract the export+codegen example for it's own example.

@jzaki jzaki requested a review from critesjosh April 9, 2024 11:38
@jzaki
Copy link
Contributor Author

jzaki commented Apr 9, 2024

Related: noir-lang/noir#4563

@jzaki
Copy link
Contributor Author

jzaki commented Apr 11, 2024

Modifying to be recursive

@jzaki jzaki closed this Apr 11, 2024
@jzaki jzaki reopened this Apr 12, 2024
@jzaki jzaki requested a review from signorecello April 12, 2024 16:07
@jzaki
Copy link
Contributor Author

jzaki commented Apr 12, 2024

Closes #197

@jzaki jzaki assigned jzaki and unassigned jzaki Apr 15, 2024
@catmcgee
Copy link
Collaborator

hey @jzaki this is for this repo - https://github.com/noir-lang/noir-examples/tree/master/recursion/packages/noir/recursion

right now it does something similar to your example here - although yours is much more concise :)

I think @signorecello's idea was to have a more practical example, eg a game

@jzaki
Copy link
Contributor Author

jzaki commented Apr 16, 2024

@catmcgee They are quite different.

@Savio-Sou
Copy link
Member

Would be great to get you guys' help on updating https://noir-lang.org/docs/how_to/how-to-recursion, perhaps following the review and merging of this PR.

Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzaki wdyt about adding some more detail to the README (e.g. about the structure of the repo)? I think it'd be helpful to give a short description of what sumLib, sum, recurseNode, and recurseLeaf all do, and how they fit together in main.ts.

@jzaki jzaki requested a review from critesjosh April 17, 2024 13:06
Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants