Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRS Transcript Cleanup #93

Merged
merged 7 commits into from
Feb 12, 2023
Merged

SRS Transcript Cleanup #93

merged 7 commits into from
Feb 12, 2023

Conversation

dbanks12
Copy link
Contributor

Copied from PR #36

  • Original author: @suyash67
  • This copy uses branches with git history restored

This PR slightly modifies the way we handle the SRS data in barretenberg.

  1. First of all, the directory structure of the transcripts changes slightly:
  2. The first monomial transcript ignition/monomial/transcript00.dat now contains 5040001 points and rest of the 19 monomial transcripts contain 5040000 points. The generator $[1]_1$ was added to transcript00.dat. This allows us to remove conditional logic on including $[1]_1$ while reading monomial transcripts.
  3. The code to generate a Lagrange transcript from a monomial transcript now also works for size $>2^{24}$. To store Lagrange transcripts with size $>2^{24}$, we split it into multiple files each containing $2^{24}$ points (file size is 1.1GB). For example, we now store the Lagrange transcript of size $2^{25}$ in $\frac{2^{25}}{2^{24}}=2$ files named transcript_ 33554432.dat and transcript_33554432_1.dat. This was done because it isn't possible to write more than 1.1GB of data to a .dat file in our code.

@suyash67 suyash67 force-pushed the sb/srs-transcript-with-history branch from 0bed278 to 1dc3ba5 Compare February 8, 2023 17:31
@ledwards2225 ledwards2225 self-requested a review February 9, 2023 18:08
Copy link
Collaborator

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@suyash67 suyash67 merged commit 12e8ae8 into master Feb 12, 2023
@suyash67 suyash67 deleted the sb/srs-transcript-with-history branch February 12, 2023 00:53
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
* Remove conditional logic on [1]_1 in reading monomial transcript.

* Enable read/write of Lagrange transcripts in multiple files for sizes > 2^24.

* Enable >2^24 Lagrange transcript downloading.

Use new monomial transcript00.dat form new folder in s3 bucket.

* Fix download lagrange igniton script.

* attempt to fix gcc build

* Luke's suggestion.

* fix

---------

Co-authored-by: Suyash Bagad <[email protected]>
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
* Remove conditional logic on [1]_1 in reading monomial transcript.

* Enable read/write of Lagrange transcripts in multiple files for sizes > 2^24.

* Enable >2^24 Lagrange transcript downloading.

Use new monomial transcript00.dat form new folder in s3 bucket.

* Fix download lagrange igniton script.

* attempt to fix gcc build

* Luke's suggestion.

* fix

---------

Co-authored-by: Suyash Bagad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants