-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRS Transcript Cleanup #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new monomial transcript00.dat form new folder in s3 bucket.
suyash67
force-pushed
the
sb/srs-transcript-with-history
branch
from
February 8, 2023 17:31
0bed278
to
1dc3ba5
Compare
ledwards2225
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
* Remove conditional logic on [1]_1 in reading monomial transcript. * Enable read/write of Lagrange transcripts in multiple files for sizes > 2^24. * Enable >2^24 Lagrange transcript downloading. Use new monomial transcript00.dat form new folder in s3 bucket. * Fix download lagrange igniton script. * attempt to fix gcc build * Luke's suggestion. * fix --------- Co-authored-by: Suyash Bagad <[email protected]>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
* Remove conditional logic on [1]_1 in reading monomial transcript. * Enable read/write of Lagrange transcripts in multiple files for sizes > 2^24. * Enable >2^24 Lagrange transcript downloading. Use new monomial transcript00.dat form new folder in s3 bucket. * Fix download lagrange igniton script. * attempt to fix gcc build * Luke's suggestion. * fix --------- Co-authored-by: Suyash Bagad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from PR #36
This PR slightly modifies the way we handle the SRS data in barretenberg.
./bootstrap.sh
incpp/
, theignition
directory would create themonomial
and thelagrange
directories which will store the respective transcripts downloaded from our s3 bucket.ignition/monomial/transcript00.dat
now contains 5040001 points and rest of the 19 monomial transcripts contain 5040000 points. The generatortranscript00.dat
. This allows us to remove conditional logic on includingtranscript_ 33554432.dat
andtranscript_33554432_1.dat
. This was done because it isn't possible to write more than 1.1GB of data to a .dat file in our code.