Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bb.js cli tests #695

Closed
wants to merge 1 commit into from
Closed

fix: bb.js cli tests #695

wants to merge 1 commit into from

Conversation

kobyhallx
Copy link
Contributor

Description

Fixes testing for bb.js clie

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
Copy link
Collaborator

ludamad commented Aug 18, 2023

Note this will need to be migrated to Aztec packages with the script and merged there. We allow admin bypass for this repo but hope to only use that for release please (and nothing going forward once Aztec has release please)

@TomAFrench
Copy link
Member

Closing in favour of AztecProtocol/aztec-packages#1694

@TomAFrench TomAFrench closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants