Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Use manifest file to update multiple javascript and c++ versioned artefacts #593

Merged
merged 1 commit into from
Jul 11, 2023
Merged

chore(ci): Use manifest file to update multiple javascript and c++ versioned artefacts #593

merged 1 commit into from
Jul 11, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Previously we were using the version of release-please that allowed us to version a single "project" -- with barretenberg.js and barretenberg(native), we have two projects which now need to be versioned. I switched to using a manifest to handle this.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@kevaundray kevaundray changed the title chore(ci): Use maifest file to update multiple javascript and c++ versioned artefacts chore(ci): Use manifest file to update multiple javascript and c++ versioned artefacts Jul 11, 2023
dbanks12
dbanks12 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray merged commit 1337989 into master Jul 11, 2023
@kevaundray kevaundray deleted the kw/workspace-release branch July 11, 2023 16:25
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@kevaundray
chore(ci): Use manifest file to update multiple javascript and c++ ve…
3236bd2 
…rsioned artefacts (AztecProtocol/barretenberg#593)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@kevaundray
chore(ci): Use manifest file to update multiple javascript and c++ ve…
02ba33c 
…rsioned artefacts (AztecProtocol/barretenberg#593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @dbanks12