Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): Runs all noir test vectors against bb and bb.js in ci. #590

Merged
merged 6 commits into from
Jul 8, 2023
Merged

chore(test): Runs all noir test vectors against bb and bb.js in ci. #590

merged 6 commits into from
Jul 8, 2023

Conversation

charlielye
Copy link
Contributor

@charlielye charlielye commented Jul 8, 2023 •
edited
Loading

Description

Runs all noir test vectors against bb and bb.js

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@charlielye charlielye changed the title Cl/acir test vectors test: Runs all noir test vectors against bb and bb.js in ci. Jul 8, 2023
@charlielye charlielye changed the title test: Runs all noir test vectors against bb and bb.js in ci. chore(test): Runs all noir test vectors against bb and bb.js in ci. Jul 8, 2023
@charlielye charlielye merged commit b083531 into master Jul 8, 2023
@charlielye charlielye deleted the cl/acir_test_vectors branch July 8, 2023 17:58
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@charlielye
chore(test): Runs all noir test vectors against bb and bb.js in ci. (A…
5847033 
…ztecProtocol/barretenberg#590)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@charlielye
chore(test): Runs all noir test vectors against bb and bb.js in ci. (A…
2d0a692 
…ztecProtocol/barretenberg#590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charlielye