Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): Add PR title validation #521

Merged
merged 4 commits into from
Jun 12, 2023
Merged

refactor(ci): Add PR title validation #521

merged 4 commits into from
Jun 12, 2023

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Jun 9, 2023 •
edited
Loading

Description

This ensures that all PRs must follow convention commit titles

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@kevaundray
Copy link
Contributor Author

Taken from the Noir repository: https://github.com/noir-lang/noir/blob/master/.github/workflows/pull-request.yml

@kevaundray kevaundray changed the title Add PR title validation feat: Add PR title validation Jun 9, 2023
@kevaundray kevaundray changed the title feat: Add PR title validation chore: Add PR title validation Jun 9, 2023
@kevaundray kevaundray changed the title chore: Add PR title validation refactor: Add PR title validation Jun 9, 2023
@kevaundray kevaundray changed the title refactor: Add PR title validation fix: Add PR title validation Jun 9, 2023
@kevaundray kevaundray changed the title fix: Add PR title validation fix(ci): Add PR title validation Jun 9, 2023
@kevaundray kevaundray changed the title fix(ci): Add PR title validation refactor(ci): Add PR title validation Jun 9, 2023
@codygunton codygunton requested a review from Rumata888 June 12, 2023 14:27
Rumata888
Rumata888 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@Rumata888 Rumata888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright. Although it is a bit sketchy using some guy's action

@Rumata888 Rumata888 merged commit 086abb4 into master Jun 12, 2023
@Rumata888 Rumata888 deleted the kw/pr-template branch June 12, 2023 17:08
@kevaundray
Copy link
Contributor Author

Yeah true -- we can git clone the repo into this organization too

ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@kevaundray
refactor(ci): Add PR title validation (AztecProtocol/barretenberg#521)
f24d805 
Enforcing release-please PR naming scheme
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@kevaundray
refactor(ci): Add PR title validation (AztecProtocol/barretenberg#521)
d7d42d8 
Enforcing release-please PR naming scheme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rumata888 Rumata888 Rumata888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @Rumata888