bug fix: UltraPlonk RAM witnesses affect verification key #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndent on witness Fixed following issues: 1. `memory_read_records`, `memory_write_records` are a function of the input witness, and should be assigned to the proving key in `compute_witness` (not `compute_proving_key`) 2. `apply_aux_selectors(AUX_SELECTORS::RAM_TIMESTAMP_CHECK)` was being called on the original ram records witnesses and NOT the set of sorted ram record witnesses
11 tasks
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…ndent on witness (AztecProtocol/barretenberg#520) Fixed following issues: 1. `memory_read_records`, `memory_write_records` are a function of the input witness, and should be assigned to the proving key in `compute_witness` (not `compute_proving_key`) 2. `apply_aux_selectors(AUX_SELECTORS::RAM_TIMESTAMP_CHECK)` was being called on the original ram records witnesses and NOT the set of sorted ram record witnesses
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…ndent on witness (AztecProtocol/barretenberg#520) Fixed following issues: 1. `memory_read_records`, `memory_write_records` are a function of the input witness, and should be assigned to the proving key in `compute_witness` (not `compute_proving_key`) 2. `apply_aux_selectors(AUX_SELECTORS::RAM_TIMESTAMP_CHECK)` was being called on the original ram records witnesses and NOT the set of sorted ram record witnesses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where UltraPlonk RAM constraints made verification key depend on witness
Fixed following issues:
memory_read_records,memory_write_recordsare a function of the input witness, and should be assigned to the proving key incompute_witness(notcompute_proving_key)apply_aux_selectors(AUX_SELECTORS::RAM_TIMESTAMP_CHECK)was being called on the original ram records witnesses and NOT the set of sorted ram record witnessesDescription
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.