-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve barretenberg headers #201
Conversation
Looks mostly good to me. We should ping the crypto team letting them know about this PR because it will likely break people's branches. But I do think this is a good change. It might make sense to move some of the C++ formatting changes into a separate PR, but I don't feel strongly either way. |
The formatting changes happened because I moved the files and the git hook applies to all files that are staged (see #192). I think it's fine to format them so all formatting is consistent as per the git hook. |
* fix!: Move the include root up 1 directory & rename aztec to barretenberg * chore: Use quote includes instead of angle brackets
* fix!: Move the include root up 1 directory & rename aztec to barretenberg * chore: Use quote includes instead of angle brackets
Description
This PR does a few things:
cpp/src/aztec
tocpp/src/barretenberg
, which will align the installed headers to match thelibbarretenberg
library that will get installed by feat: Add installation targets for libbarretenberg, wasm & headers #185cpp/src/aztec/CMakeLists.txt
tocpp/src/CMakeLists.txt
which allows all header files to be prefixed with thebarretenberg
namespace. This ensures that header includes when building the project are the same as when installed.barretenberg/
prefix.Checklist:
/markdown/specs
have been updated.@brief
describing the intended functionality.