Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make pedersen commit function public #170

Merged
merged 1 commit into from
Mar 1, 2023
Merged

feat: Make pedersen commit function public #170

merged 1 commit into from
Mar 1, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 21, 2023

Description

Noir needs the pedersen commit function to be public because it needs to be able to return the x and y.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated changed the title feat!: Make pedersen commit function public feat: Make pedersen commit function public Feb 21, 2023
adr1anh
adr1anh approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@adr1anh adr1anh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy change, looks good to me.

@ledwards2225 ledwards2225 force-pushed the phated/noir-needs-1 branch from eb333bc to 389b297 Compare March 1, 2023 16:18
@codygunton codygunton merged commit da7bfd6 into master Mar 1, 2023
@codygunton codygunton deleted the phated/noir-needs-1 branch March 1, 2023 20:18
@Savio-Sou Savio-Sou added this to the UltraPlonk in Noir milestone Mar 6, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@phated @kevaundray
NOIR NEEDS: make commit a public function since noir needs to be able…
f8c030e 
… to return the x and y coos (AztecProtocol/barretenberg#170)

Co-authored-by: kevaundray <[email protected]>
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@phated @kevaundray
NOIR NEEDS: make commit a public function since noir needs to be able…
255bff3 
… to return the x and y coos (AztecProtocol/barretenberg#170)

Co-authored-by: kevaundray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adr1anh adr1anh adr1anh approved these changes

@arielgabizon arielgabizon Awaiting requested review from arielgabizon

@codygunton codygunton Awaiting requested review from codygunton

@kevaundray kevaundray Awaiting requested review from kevaundray

@dbanks12 dbanks12 Awaiting requested review from dbanks12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phated @adr1anh @codygunton @Savio-Sou @kevaundray