Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add needed 'redundant' checks. #157

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add needed 'redundant' checks. #157

merged 1 commit into from
Feb 17, 2023

Conversation

codygunton
Copy link
Collaborator

@codygunton codygunton commented Feb 17, 2023 •
edited
Loading

Description

clang-tidy has some duplicated checks with different names. In order to suppress these checks, we have to suppress for both names.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@codygunton codygunton marked this pull request as ready for review February 17, 2023 04:26
@codygunton
Copy link
Collaborator Author

This is a tiny an uncontroversial PR that does not need review.

@codygunton codygunton merged commit aea3f8d into master Feb 17, 2023
@codygunton codygunton deleted the cg/missing-checks branch February 17, 2023 04:27
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@codygunton
Add needed 'redundant' checks. (AztecProtocol/barretenberg#157)
4239740
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@codygunton
Add needed 'redundant' checks. (AztecProtocol/barretenberg#157)
6e97671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codygunton