Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid targeting honk test files when testing is disabled #125

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix: Avoid targeting honk test files when testing is disabled #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions cpp/src/aztec/honk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
barretenberg_module(honk numeric ecc srs proof_system transcript)

# TODO: Re-enable all these warnings once PoC is finished
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(
honk_test_objects
PRIVATE
-Wno-error=unused-variable
)
elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
target_compile_options(
honk_test_objects
PRIVATE
-Wno-error=maybe-uninitialized
-Wno-error=uninitialized
-Wno-error=unused-variable
)
endif()
if(TESTING)
# TODO: Re-enable all these warnings once PoC is finished
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(
honk_test_objects
PRIVATE
-Wno-error=unused-variable
)
elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
target_compile_options(
honk_test_objects
PRIVATE
-Wno-error=maybe-uninitialized
-Wno-error=uninitialized
-Wno-error=unused-variable
)
endif()
endif()