Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies/location of files (relating to PG, possibly others) #854

Closed
lucasxia01 opened this issue Feb 16, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#5066
Closed

Fix dependencies/location of files (relating to PG, possibly others) #854

lucasxia01 opened this issue Feb 16, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#5066
Assignees
@lucasxia01
Labels
cleanup

Comments

@lucasxia01
Copy link
Contributor

Currently ultra_honk depends on protogalaxy because the composer has protogalaxy related functions. However, after the composer is eliminated, we can remove this dependence.

As a result of this dependence, the shared prover/verifier code is placed in protogalaxy temporarily, but should be moved to ultra_honk.
@lucasxia01 lucasxia01 changed the title Fix dependencies/location of files Fix dependencies/location of files (relating to PG, possibly others) Feb 16, 2024
@lucasxia01 lucasxia01 mentioned this issue Mar 7, 2024
Merged
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 7, 2024
@lucasxia01
fix: update protogalaxy cmake dependencies (#5066)
507c374 
Closes AztecProtocol/barretenberg#854.

We previously had to make ultra_honk dependent on protogalaxy because we
had the ultra composer in the ultra_honk folder, and that composer had
protogalaxy related functions. Now, with the composer dead, we can have
the correct dependency, which is going the other way.

Old graph:

![barretenberg_modules](https://github.com/AztecProtocol/aztec-packages/assets/42556996/99866e8d-eaa8-45de-855e-d2c886c4f0a0)

New graph:

![barretenberg_modules](https://github.com/AztecProtocol/aztec-packages/assets/42556996/210301b2-abb9-469b-a6b3-c50832f318fa)

No benchmarking update since this should not affect it.
@lucasxia01 lucasxia01 self-assigned this Mar 7, 2024
AztecBot pushed a commit that referenced this issue Mar 8, 2024
@lucasxia01 @AztecBot
fix: update protogalaxy cmake dependencies (#5066)
9792646 
Closes #854.

We previously had to make ultra_honk dependent on protogalaxy because we
had the ultra composer in the ultra_honk folder, and that composer had
protogalaxy related functions. Now, with the composer dead, we can have
the correct dependency, which is going the other way.

Old graph:

![barretenberg_modules](https://github.com/AztecProtocol/aztec-packages/assets/42556996/99866e8d-eaa8-45de-855e-d2c886c4f0a0)

New graph:

![barretenberg_modules](https://github.com/AztecProtocol/aztec-packages/assets/42556996/210301b2-abb9-469b-a6b3-c50832f318fa)

No benchmarking update since this should not affect it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasxia01 lucasxia01

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update protogalaxy cmake dependencies AztecProtocol/aztec-packages
1 participant
@lucasxia01