Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACIR: Document witness_buf_to_witness_data #824

Closed
ledwards2225 opened this issue Jan 10, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#3940
Closed

ACIR: Document witness_buf_to_witness_data #824

ledwards2225 opened this issue Jan 10, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#3940

Comments

@ledwards2225
Copy link
Collaborator

This method has some complicated logic that at first look appeared to be related to the const 0 variable noir offset issue #816. It is actually somewhat unrelated and appears to be a mechanism for inserting "placeholder" 0's intermittently in the witness, perhaps when the presence of these witnesses are known to acir but their values are not known. Discuss with @kevaundray.

Note that this is somewhat related to #816 because once the +1 offset is removed from noir, index 0 again becomes a valid witness index and no longer necessarily corresponds to the variable 0. So these "placeholder" 0's will now point to some non-zero variable.
@TomAFrench TomAFrench mentioned this issue Jan 11, 2024
Merged
kevaundray added a commit to AztecProtocol/aztec-packages that referenced this issue Jan 11, 2024
@TomAFrench @kevaundray
chore: document witness_buf_to_witness_data (#3940)
fbaa726 
Closes AztecProtocol/barretenberg#824

---------

Co-authored-by: kevaundray <[email protected]>
AztecBot pushed a commit that referenced this issue Jan 12, 2024
@TomAFrench @kevaundray @AztecBot
chore: document witness_buf_to_witness_data (#3940)
326e80b 
Closes #824

---------

Co-authored-by: kevaundray <[email protected]>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@TomAFrench @kevaundray
chore: document witness_buf_to_witness_data (AztecProtocol#3940)
8f80ac7 
Closes AztecProtocol/barretenberg#824

---------

Co-authored-by: kevaundray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: document witness_buf_to_witness_data AztecProtocol/aztec-packages
1 participant
@ledwards2225