Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZM in ECCVM #769

Closed
ledwards2225 opened this issue Nov 17, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#5246
Closed

ZM in ECCVM #769

ledwards2225 opened this issue Nov 17, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#5246
Assignees

Comments

@ledwards2225
Copy link
Collaborator

ledwards2225 commented Nov 17, 2023

Replace Gemini/Shplonk in ECCVM with Zeromorph. I believe using IPA with ZM automatically handles the final degree check so the protocol is identical to the one used elsewhere but we don't have to do the final shift to degree N_max as we do with KZG. We still need to compute the batched-raised-degree multilinear quotient $\hat{q}$ in order to achieve the 2^k-degree checks on $q_k$.

One more change needed for this work: ZM was implemented with KZG in mind so the return of verify is the set of inputs to the KZG pairing check. ZM needs to be made agnostic to the final univariate PCS (KZG/IPA).

@ledwards2225 ledwards2225 self-assigned this Nov 17, 2023
@codygunton codygunton removed their assignment Mar 18, 2024
maramihali added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 21, 2024
Resolves AztecProtocol/barretenberg#769.
Resolves AztecProtocol/barretenberg#782.

Generalise Zeromorph further to be able to instantiate with both KZG and
IPA and switch ECCVM to use Zeromorph + IPA. This PR also fixes a small
inconsistency in Zeromorph where we assumed that first element of the
SRS is always going to be [1]_1 which is not the case if we work on
Grumpkin. Unskip and complete eccvm transcript tests.
AztecBot pushed a commit that referenced this issue Mar 22, 2024
Resolves #769.
Resolves #782.

Generalise Zeromorph further to be able to instantiate with both KZG and
IPA and switch ECCVM to use Zeromorph + IPA. This PR also fixes a small
inconsistency in Zeromorph where we assumed that first element of the
SRS is always going to be [1]_1 which is not the case if we work on
Grumpkin. Unskip and complete eccvm transcript tests.
sklppy88 pushed a commit to AztecProtocol/aztec-packages that referenced this issue Mar 22, 2024
Resolves AztecProtocol/barretenberg#769.
Resolves AztecProtocol/barretenberg#782.

Generalise Zeromorph further to be able to instantiate with both KZG and
IPA and switch ECCVM to use Zeromorph + IPA. This PR also fixes a small
inconsistency in Zeromorph where we assumed that first element of the
SRS is always going to be [1]_1 which is not the case if we work on
Grumpkin. Unskip and complete eccvm transcript tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants