Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor relations for use in computation of the perturbation and combiner polynomials #685

Closed
codygunton opened this issue Aug 18, 2023 · 1 comment
Closed

Refactor relations for use in computation of the perturbation and combiner polynomials #685

codygunton opened this issue Aug 18, 2023 · 1 comment
Assignees
@codygunton
Milestone
Protogalaxy

Comments

@codygunton
Copy link
Collaborator

No description provided.

@codygunton codygunton added this to the Protogalaxy milestone Aug 18, 2023
@codygunton codygunton self-assigned this Aug 21, 2023
@codygunton codygunton mentioned this issue Aug 30, 2023
Merged
4 tasks
codygunton added a commit to AztecProtocol/aztec-packages that referenced this issue Sep 7, 2023
@codygunton
refactor: protogalaxy relations (#1897)
35407e2 
Will resolve AztecProtocol/barretenberg#682
and AztecProtocol/barretenberg#685

- Add optimization to `extend` functions in `BarycentricData`.
- Move barycentric evaluation, univariate, and relations classes for
organizations and more efficient iteration.
- Simplify relations classes.
- Simplify relation consistency tests.

Cf also my comments below.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
AztecBot pushed a commit that referenced this issue Sep 7, 2023
@codygunton @AztecBot
refactor: protogalaxy relations (#1897)
827b813 
Will resolve #682
and #685

- Add optimization to `extend` functions in `BarycentricData`.
- Move barycentric evaluation, univariate, and relations classes for
organizations and more efficient iteration.
- Simplify relations classes.
- Simplify relation consistency tests.

Cf also my comments below.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@codygunton
Copy link
Collaborator Author

Closed by AztecProtocol/aztec-packages#1897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codygunton codygunton

Labels
None yet
Projects
None yet
Milestone
Protogalaxy
Development

No branches or pull requests
1 participant
@codygunton