Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup release-please workflow #601

Closed
6 tasks done
kevaundray opened this issue Jul 12, 2023 · 1 comment · Fixed by AztecProtocol/aztec-packages#1837
Closed
6 tasks done

Cleanup release-please workflow #601

kevaundray opened this issue Jul 12, 2023 · 1 comment · Fixed by AztecProtocol/aztec-packages#1837
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Jul 12, 2023

The following are tasks that need to be done to clean-up the release-please workflow:

@kevaundray kevaundray added the enhancement New feature or request label Jul 12, 2023
@kevaundray
Copy link
Contributor Author

The above list was generated from Charlies offline review.

Need to investigate if we need to save two WASM binaries: the one that we generate using the wasm-threads preset and the one we generate using the wasm preset.

kevaundray added a commit to AztecProtocol/aztec-packages that referenced this issue Aug 28, 2023
resolves #1836 
resolves AztecProtocol/barretenberg#601

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
AztecBot pushed a commit that referenced this issue Aug 28, 2023
resolves #1836 
resolves #601

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant