Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete acir_tests suite for Honk #1124

Closed
maramihali opened this issue Oct 7, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#9042
Closed

Complete acir_tests suite for Honk #1124

maramihali opened this issue Oct 7, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#9042
Assignees

Comments

@maramihali
Copy link
Contributor

maramihali commented Oct 7, 2024

We are missing the double_verify* Acir tests for Honk

codygunton pushed a commit to AztecProtocol/aztec-packages that referenced this issue Oct 7, 2024
Closes AztecProtocol/barretenberg#1124.

Ensure all acir tests are configured to run with UH as a precursor to the full switch and add `double_verify_honk_proof` and `double_verify_honk_proof_recursive` Noir programs to be tested as part of the acir tests. In Plonk, we also have `double_verify_nested_proof`, which aggregates two recursive proof (produced with `double_verify_proof_recursive`). That is because those proofs will have 16  additional frs representing the public inputs' indices of the recursive proof. Unlike this, we don't have different proof sizes when we handle recursive proofs for Honk but instead parse an initial default aggregation object in case the proof isn't produced from recursively verifying another proof.
AztecBot pushed a commit that referenced this issue Oct 8, 2024
Closes #1124.

Ensure all acir tests are configured to run with UH as a precursor to the full switch and add `double_verify_honk_proof` and `double_verify_honk_proof_recursive` Noir programs to be tested as part of the acir tests. In Plonk, we also have `double_verify_nested_proof`, which aggregates two recursive proof (produced with `double_verify_proof_recursive`). That is because those proofs will have 16  additional frs representing the public inputs' indices of the recursive proof. Unlike this, we don't have different proof sizes when we handle recursive proofs for Honk but instead parse an initial default aggregation object in case the proof isn't produced from recursively verifying another proof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant