Skip to content

Commit

Permalink
chore: Address comments (#4772)
Browse files Browse the repository at this point in the history
AztecProtocol/aztec-packages#4752 got merged in
automatically, so I'm addressing comments in a separate PR. This is
totally not an airdrop mining strategy
  • Loading branch information
Rumata888 authored and AztecBot committed Feb 28, 2024
1 parent 7b1e6e2 commit 9ba2e94
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ std::vector<ECCOpQueue::ECCVMOperation> parse_operations(const unsigned char* da
}

/**
* @brief Try to parse out the batching and evaluating challenges and then the ECCOpQUeue from the data
* @brief Try to parse out the batching and evaluating challenges and then the ECCOpQueue from the data
*
* @param data pointer to the buffer
* @param size size of the buffer
Expand Down Expand Up @@ -79,6 +79,6 @@ std::optional<std::tuple<Fq, Fq, std::shared_ptr<ECCOpQueue>>> parse_and_constru
ecc_op_queue->raw_ops = raw_ops;
ecc_op_queue->mul_accumulate(padding_element, padding_scalar);

// Create circuit builder and feed the queue inside
// Return the batching challenge, evaluation challenge and the constructed queue
return std::make_tuple(batching_challenge, x, ecc_op_queue);
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
extern "C" int LLVMFuzzerTestOneInput(const unsigned char* data, size_t size)
{
// Parse the queue and challenges
// TODO(Rumata888): composer generates the initial challenge through FS, so we have to do that, too
// TODO(https://github.com/AztecProtocol/barretenberg/issues/869): composer generates the initial challenge through
// FS, so we have to do that, too
auto parsing_result = parse_and_construct_opqueue(data, size);
if (!parsing_result.has_value()) {
return 0;
Expand Down

0 comments on commit 9ba2e94

Please sign in to comment.