chore(ci): Re-enable certain bb solidity ACIR tests (#5065)

It isn't clear after some of the recursion cleanup in AztecProtocol/aztec-packages#4221 why `double_verify_proof` is failing the solidity verifier. `double_verify_proof` was being used as a recursive proof itself to be verified inside of `double_verify_nested_proof`. I have renamed this test to `double_verify_proof_recursive` to note that its proof should be used as input to another circuit. I have also included a new test `double_verify_proof` where we accept two non-nested proofs and use the Keccak prover. This is what we were previously expecting for `double_verify_proof`. I also brought back `arretenberg-acir-tests-bb-sol` for a few tests. --------- Co-authored-by: Maddiaa <[email protected]>
AztecProtocol · Mar 9, 2024 · 31b940b · 31b940b
1 parent 9792646
commit 31b940b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/acir_tests/Dockerfile.bb.sol b/acir_tests/Dockerfile.bb.sol
@@ -10,6 +10,12 @@ COPY --from=noir-acir-tests /usr/src/noir/noir-repo/test_programs /usr/src/noir/
 COPY --from=ghcr.io/foundry-rs/foundry:latest /usr/local/bin/anvil /usr/local/bin/anvil
 WORKDIR /usr/src/barretenberg/acir_tests
 COPY . .
-# Run every acir test through a solidity verifier.
+# Run the relevant acir tests through a solidity verifier.
+# This includes the basic `assert_statement` test that contains a single public input
+# and the recursive aggregation circuits which use the Keccak based prover.
+#
+# NOTE: When circuits are marked `recursive` it means the backend will use a prover that
+# produces SNARK recursion friendly proofs, while the solidity verifier expects proofs
+# whose transcript uses Keccak hashing. 
 RUN (cd sol-test && yarn)
-RUN PARALLEL=1 FLOW=sol ./run_acir_tests.sh
+RUN PARALLEL=1 FLOW=sol ./run_acir_tests.sh assert_statement double_verify_proof double_verify_nested_proof
diff --git a/acir_tests/README.md b/acir_tests/README.md
@@ -59,4 +59,4 @@ To generate a new input you can run the script again. To generate a new file und
 
 You can then copy these inputs over to your working branch in Noir and regenerate the witness for `double_verify_proof`. You can then change the branch in `run_acir_tests.sh` to this Noir working branch as well and `double_verify_proof` should pass.
 
-The same process should then be repeated, but now `double_verify_proof` will be the circuit for which we will be generating recursive inputs using `gen_inner_proof_inputs.sh`. The recursive artifacts should then supplied as inputs to `double_verify_nested_proof`. 
+The same process should then be repeated, but now `double_verify_proof_recursive` will be the circuit for which we will be generating recursive inputs using `gen_inner_proof_inputs.sh`. The recursive artifacts should then supplied as inputs to `double_verify_nested_proof`.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -59,4 +59,4 @@ To generate a new input you can run the script again. To generate a new file und

		You can then copy these inputs over to your working branch in Noir and regenerate the witness for `double_verify_proof`. You can then change the branch in `run_acir_tests.sh` to this Noir working branch as well and `double_verify_proof` should pass.

		The same process should then be repeated, but now `double_verify_proof` will be the circuit for which we will be generating recursive inputs using `gen_inner_proof_inputs.sh`. The recursive artifacts should then supplied as inputs to `double_verify_nested_proof`.
		The same process should then be repeated, but now `double_verify_proof_recursive` will be the circuit for which we will be generating recursive inputs using `gen_inner_proof_inputs.sh`. The recursive artifacts should then supplied as inputs to `double_verify_nested_proof`.