Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new kernel interface, base rollup cbinds + tests #115

Merged
merged 42 commits into from
Mar 29, 2023

Conversation

dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Mar 28, 2023

Description

Base rollup stuff

  • Add cbinds for base rollup circuit
  • Add a function that will rerun each base rollup test via cbinds
    • Bug found in [de]serialization, so some final public input checks are commented out

Private kernel stuff

  • Helper function to create mock previous kernel for use by private kernel and base rollup
  • New/simplified interface to the private kernel (separate prove and simulate)
  • Combine circuit + native cbind private kernel tests into a single test

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

Note
If you are updating the submodule, please make sure you do it in its own special PR and avoid making changes to the submodule as a part of other PRs.
To update a submodule, you can run the following commands:

$ git submodule update --recursive

Alternatively, you can select a particular commit in barretenberg/aztec3 that you wish to point to:

$ cd barretenberg
$ git pull origin aztec3        # This will point to the latest commit in `barretenberg/aztec3`
$ git checkout <commit_hash>    # Use this if you wish to point to a particular commit.
$ cd ..
$ git add . && git commit -m <commit_msg>
$ git push

dbanks12 and others added 30 commits March 28, 2023 11:25
* refactor(merge): seperate merge and base rollup

* initial test setup

* fix(ts-bindings): reduce roots to calldatahash

* fix: remove prover id

* fix: base rollup pub inputs ts tests

* remove deps

* rm gtest

* fix: scuffed rebase

* fix: scuffed rebase cont.

* fix: update tests

---------

Co-authored-by: cheethas <[email protected]>
Co-authored-by: LHerskind <[email protected]>
* update inputs and outputs of base per new miro dg

* update types and bindings

* fix ts bindings for base
LHerskind and others added 6 commits March 28, 2023 19:33
* tests: tiny tests added

* fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields

* fix: run tests in ci + remove log

* fix: fix tests

* fix: fix comments

* fix: better comment
* insert commitments and contracts into end trees

* fix merkle membership refactoring

* add new root to snapshot

* fix per pr comments

* update ts constants

* fix per pr comments
@dbanks12 dbanks12 changed the title New private kernel interface feat: new kernel interface, start base rollup cbinds Mar 28, 2023
@dbanks12 dbanks12 changed the base branch from master to md/base_rollup March 28, 2023 20:35
Base automatically changed from md/base_rollup to master March 28, 2023 21:20
@dbanks12 dbanks12 changed the title feat: new kernel interface, start base rollup cbinds feat: new kernel interface, base rollup cbinds + tests Mar 28, 2023
@iAmMichaelConnor iAmMichaelConnor merged commit 8b36f95 into master Mar 29, 2023
@iAmMichaelConnor iAmMichaelConnor deleted the db/new_private_kernel_interface branch March 29, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants