-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new kernel interface, base rollup cbinds + tests #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(merge): seperate merge and base rollup * initial test setup * fix(ts-bindings): reduce roots to calldatahash * fix: remove prover id * fix: base rollup pub inputs ts tests * remove deps * rm gtest * fix: scuffed rebase * fix: scuffed rebase cont. * fix: update tests --------- Co-authored-by: cheethas <[email protected]> Co-authored-by: LHerskind <[email protected]>
…uits into md/base_rollup
* update inputs and outputs of base per new miro dg * update types and bindings * fix ts bindings for base
* tests: tiny tests added * fix: insert zero-leaf in contract + use sha256 + change calldata hash -> 2 fields * fix: run tests in ci + remove log * fix: fix tests * fix: fix comments * fix: better comment
* insert commitments and contracts into end trees * fix merkle membership refactoring * add new root to snapshot * fix per pr comments * update ts constants * fix per pr comments
dbanks12
changed the title
New private kernel interface
feat: new kernel interface, start base rollup cbinds
Mar 28, 2023
dbanks12
changed the title
feat: new kernel interface, start base rollup cbinds
feat: new kernel interface, base rollup cbinds + tests
Mar 28, 2023
dbanks12
requested review from
Maddiaa0,
LHerskind,
rahul-kothari,
suyash67 and
iAmMichaelConnor
March 28, 2023 23:08
iAmMichaelConnor
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base rollup stuff
Private kernel stuff
Checklist:
/specs
have been updated.@brief
describing the intended functionality.