This repository has been archived by the owner on May 18, 2023. It is now read-only.
Lh/ultra yul flatten #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHerskind
force-pushed
the
lh/ultra-yul-flatten
branch
from
b80ba36 to
9f1b5e6
Compare
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #11 to also flatten the ultra-plonk verifier. Adds a large amount of comments throughout the code. Not super consistent on notation though 😅.
The flattening increased gas costs a tiny bit, but the readability should be much better, and should be easier to validate that the solidity and cpp implementations have parity.
Flattening made verification gas costs go from
375524to376062(increase of538gas) for theadd2circuit.