feat: new proving agent #9999
Merged
feat: new proving agent #9999
+647
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
force-pushed
the
ag/proving-agent
branch
from
8785bcb
to
1abdd86
Compare
alexghr
commented
Nov 15, 2024
| if (err) { | ||
| return this.jobSource.reportProvingJobError(job.id, err); | ||
| } else if (result) { | ||
| return this.jobSource.reportProvingJobSuccess(job.id, result); |
There was a problem hiding this comment.
This should retry sending the result. I'm deliberating whether the agent should retry sending it explicitely or if it should be handled transparently by the rpc client.
alexghr
commented
Nov 15, 2024
| @@ -30,7 +41,7 @@ import { | |||
| export class MockProver implements ServerCircuitProver { | |||
| constructor() {} | |||
|
|
|||
| getAvmProof() { | |||
| getAvmProof(_inputs: AvmCircuitInputs, _signal?: AbortSignal, _epochNumber?: number) { | |||
There was a problem hiding this comment.
I needed to add all these parameters from the interface in order to be able to use them in mocks.
alexghr
force-pushed
the
ag/proving-agent
branch
from
1abdd86
to
1ef6e26
Compare
PhilWindle
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New proving agent for proving broker. Fix #9533
LE: PR 9999!!