feat: mock data for IVC #9893
Merged
feat: mock data for IVC #9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
commented
Nov 12, 2024
| { | ||
| size_t total_size = 0; |
There was a problem hiding this comment.
I think this being 0 was just a bug that never showed up in any tests since +1 never made a difference in the dyadic size
There was a problem hiding this comment.
interesting. I guess we need more tests for borderline circuit sizes
There was a problem hiding this comment.
yeah I only caught it because I accidentally propagated it to Ultra where we do just happen to have a case that's right on the line
ledwards2225
commented
Nov 12, 2024
| for (auto block : this->get()) { | ||
| total_size += block.get_fixed_size(); | ||
| } | ||
| return total_size; | ||
|
|
There was a problem hiding this comment.
just an update to allow this method to compute the dyadic size itself since this is how it was always being used
ledwards2225
commented
Nov 12, 2024
| @@ -75,39 +76,11 @@ class IvcRecursionConstraintTest : public ::testing::Test { | |||
| }; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Removing this test because it was a pain to keep updating and is also no longer relevant because the kernel circuits will not do anything with public inputs anymore since the introduction of the databus.
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
lucasxia01
approved these changes
Nov 12, 2024
| // Construct kernel consisting only of the kernel completion logic | ||
| AcirProgram program = construct_mock_kernel_program(ivc.verification_queue, { num_app_public_inputs }); | ||
| Builder kernel = acir_format::create_kernel_circuit(program.constraints, ivc); | ||
| // WORKTODO: this would normally happen in accumulate() |
| { | ||
| size_t total_size = 0; |
There was a problem hiding this comment.
interesting. I guess we need more tests for borderline circuit sizes
| Builder app_circuit = construct_mock_app_circuit(ivc); | ||
| ivc.accumulate(app_circuit); | ||
| // Test generation of "init" kernel VK via dummy IVC data | ||
| TEST_F(IvcRecursionConstraintTest, GenerateVKFromConstraints) |
There was a problem hiding this comment.
what's missing from this test?
There was a problem hiding this comment.
not sure what you mean - I wouldn't say anything is missing, its just that right now I'm only supporting the mocking of the IVC state after accumulation of the first app. All that's needed I suppose is functionality to mock fold proofs which shouldn't be hard
TomAFrench
added a commit
that referenced
this pull request
Nov 13, 2024
* master: git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: mock data for IVC (#9893) refactor: final token cleanup (#9864) chore: delete accidentally added file (#9912)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental work towards a write_vk flow for kernel circuits. kernel circuits are generated from acir via the method
acir_format::create_kernel_circuit()which takes as input the raw acir data plus a ClientIvc instance containing the proofs to be recursively verified in that circuit (Oink/PG + merge). In the context of VK generation, those proofs are not yet known, so the IVC state has to be mocked. This PR adds such functionality but only for the oink case (i.e. the state of the IVC after accumulating the first app which only calls the pink prover). Equivalent logic for mocking the state after subsequent accumulations will be handled in a follow on.