chore: more descriptive slack alert #9739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanks12
approved these changes
Nov 6, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
984
to
985
| # Collect failed jobs from needs | ||
| FAILED_JOBS_JSON: ${{ toJson(needs) }} |
There was a problem hiding this comment.
Are these actually the failed jobs or just all jobs that this one "needs"? If the latter then the comment and variable name are misleading.
Based on the run rule below, it looks like it's the latter, and the run rule extracts the ones that failed. But also I don't really know what I'm looking at!
There was a problem hiding this comment.
Good call, this is poorly named
codygunton
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.