refactor: token partial notes refactor pt. 2 - bridging #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
b5e9766 to
79870df
Compare
benesjan
changed the base branch from
master
to
10-31-refactor_nuking_pay_refund_with_shielded_rebate_flow
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
2 times, most recently
from
9344ac0 to
5baeda8
Compare
Base automatically changed from
10-31-refactor_nuking_pay_refund_with_shielded_rebate_flow
to
master
November 8, 2024 16:57
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
5baeda8 to
c1a8e42
Compare
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
581ee9e to
ef1b833
Compare
benesjan
changed the title
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
ef1b833 to
e5b74cb
Compare
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
e5b74cb to
c7e984b
Compare
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
c7e984b to
dcbcd38
Compare
benesjan
commented
Nov 11, 2024
| @@ -22,11 +22,7 @@ contract TokenPortal { | |||
| ); | |||
|
|
|||
| event DepositToAztecPrivate( | |||
| bytes32 secretHashForRedeemingMintedNotes, | |||
There was a problem hiding this comment.
This ^ was the hash in the transparent note. It's no longer there (and neither is L2 address) meaning that only the message secret "owns" the bridged tokens.
benesjan
commented
Nov 11, 2024
| @@ -27,15 +27,15 @@ contract TokenBridge { | |||
| // Storage structure, containing all storage, and specifying what slots they use. | |||
| #[storage] | |||
| struct Storage<Context> { | |||
| token: PublicMutable<AztecAddress, Context>, | |||
| token: SharedImmutable<AztecAddress, Context>, | |||
There was a problem hiding this comment.
We now need to read this in private as well so changed PublicMutable to Shared.
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
d1b498f to
0752c7a
Compare
benesjan
commented
Nov 11, 2024
| #[private] | ||
| fn claim_private( | ||
| secret_hash_for_redeeming_minted_notes: Field, // secret hash used to redeem minted notes at a later time. This enables anyone to call this function and mint tokens to a user on their behalf | ||
| recipient: AztecAddress, // recipient of the bridged tokens |
There was a problem hiding this comment.
We are no longer redeeming "to" a TransparentNote and instead we just mint a real ValueNote to a recipient.
benesjan
commented
Nov 11, 2024
| @@ -478,7 +478,7 @@ contract Token { | |||
| let token = Token::at(context.this_address()); | |||
|
|
|||
| // We prepare the transfer. | |||
| let hiding_point_slot = _prepare_transfer_to_private(to, &mut context, storage); | |||
| let hiding_point_slot = _prepare_transfer_to_private(from, to, &mut context, storage); | |||
There was a problem hiding this comment.
We now pass the from param as it allows us to define the recipient of outgoing.
benesjan
force-pushed
the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
from
3f31918 to
90ecd6f
Compare
benesjan
deleted the
10-30-refactor_token_partial_notes_reefactor_pt._2_-_bridging
branch
This was referenced Nov 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the token partial notes refactor now focused on token bridging.