fix: Resolution of bugs from bigfield audits#9547

Merged

Rumata888 merged 36 commits intomasterfrom is/bigfield_fixes_from_3_venodors

Oct 31, 2024

+991-456

Commits on Oct 30, 2024

cmake fix
Rumata888
committed
Fix for issue 1 (ZKS.00) "Deduplicating Cached Multiplications Leaves
Rumata888
committed
Fix for issue 2 (ZKS.02, SPB.3.1.1) Unconstrained exponent
Rumata888
committed
Fix for issue 3 (ZKS.03, SPB.3.2.1) Unconstrained limbs in exponentiation and issue 15 (ZKS.0a) Handling of constant exponents
Rumata888
committed
Fix for issue 4 (ZKS.01, ZLC.3.4, SPB 3.1.2) Broken bigfield constructor for non-normalized inputs
Rumata888
committed
Fix for issue 5 (ZKS.04, ZLC.3.1, ZLC.3.2, SPB3.3.2) Maximum Limb Size Fails to Ensure Multiplication Soundness
Rumata888
committed
Fix for issue 6 (ZKS.05) Broken Bigfield Constructor for Fields of Odd Bitlength
Rumata888
committed
Fix for issue 7 (ZKS.06, SPB.3.4.1) Swapped Range Constraints on Carries
Rumata888
committed
Fix for issue 8 (ZKS.07, ZLC3.5, ZLC3.6, SPB3.5.6) Unsafe Constructors Allow Breaking Core Invariant
Rumata888
committed
Fix for issue 9 (ZLC.3.3) Underflow possible in evaluate_non_native_field_multiplication

Sarkoxed
authored and
Rumata888
committed
Fix for issue 10 (SPB.3.3.1) to_byte_array can have aliases
Rumata888
committed
Fix for issue 11 (ZKS.0b, ZLC.3.7) Proving that multiples of p are unequal to 0 modulo p possible
Rumata888
committed
Fix for issue 12 (ZKS.09) Maximum High Carry Too Small
Rumata888
committed
Fix for issue 13 (ZLC.3.8) Equation checks not enforced
Rumata888
committed
Fix for issue 14 (ZLC.3.11) Null-pointer dereference
Rumata888
committed
Fix for issue 16 (ZKS.0e, ZLC.3.12) Handling of max argument to Limb constructor
Rumata888
committed
Fix for issue 17 (SPB.3.4.2) Assertion needed to prevent bypass range-checks in unsafe_evaluate_multiply_add
Rumata888
committed
Fix for issue 19 (ZLC.3.9) Large limbs for constant inputs to conditional_negate
Rumata888
committed
Fix for issue 20 (ZLC.3.10) Incomplete constant check
Rumata888
committed
Fix for issue 22 (ZLC.3.14) Behavior of assert_equal for constant operands
Rumata888
committed
Fix for issue 23 (ZLC.3.15) Assert for add_to_lower_limb could be ineffective due to overflow
Rumata888
committed
Fix for informational issue Missing limb maximum-value check
Rumata888
committed
Fix for informational issue Equality comparison for null-pointer context
Rumata888
committed
Fix for informational issue Maximum Carry Size Can Underflow 0
Rumata888
committed
Fix for informational issue Redundant Normalize (also fixed a soundness issue in field)
Rumata888
committed
Fix for informational issue Redundant Bigfield Reduction
Rumata888
committed
Fix for informational issue Mixing Constant and Variable Limbs Is Not Supported
Rumata888
committed
Fix for informational issue Moduli With 249 Bits Or Less Are Not Supported
Rumata888
committed
Fix for informational issue Unnecessary duplicated code in assert_equal
Rumata888
committed
Fix for informational issue Unnecessary duplicated code
Rumata888
committed
Fix for informational issue Operator overloading for division is dangerous
Rumata888
committed
Fix for informational issue Code duplication in assert_*
Rumata888
committed
Fix for informational issue assert_equal with a constant without self_reduce could fail. Added comment
Rumata888
committed
format fix
Rumata888
committed

Commits on Oct 31, 2024