-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sol shplemini in acir tests + contract_gen #8874
Merged
Merged
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d517877
feat: add shplemini transcript
Maddiaa0 a838f12
feat: shplemini verification
Maddiaa0 cb1be8a
feat: shplemini
Maddiaa0 993c70a
fix: remove log
Maddiaa0 9e1fe70
Merge branch 'master' into md/sol-shplemini
Maddiaa0 d3555e2
feat: for other circuit types
Maddiaa0 1e7801d
Merge branch 'master' into md/sol-shplemini
Maddiaa0 296d579
Merge branch 'md/sol-shplemini' into md/sol-shplemini-impl
Maddiaa0 c7c0768
fix: typo
Maddiaa0 e17684b
fmt
Maddiaa0 ea948a0
feat: add to honk_contract.hpp
Maddiaa0 01a49ce
chore: adjust readme warning
Maddiaa0 cacf935
fix
Maddiaa0 052f149
fix: remove proof slicing
Maddiaa0 52df235
Merge branch 'master' into md/sol-shplemini
Maddiaa0 d03d034
fix: rename geminiComms
Maddiaa0 ee4b0b2
Merge branch 'md/sol-shplemini' into md/sol-shplemini-impl
Maddiaa0 3a14d5d
Merge branch 'md/sol-shplemini-impl' into md/shplemini-in-noir-output
Maddiaa0 ca844d7
fix: update vks and merge fix
Maddiaa0 d85bbd6
Merge branch 'md/sol-shplemini-impl' into md/shplemini-in-noir-output
Maddiaa0 0690aee
fix: merge update honk_contract.hpp
Maddiaa0 3965bad
Merge branch 'master' into md/shplemini-in-noir-output
Maddiaa0 3e970d5
review: feedback
Maddiaa0 94a2a89
chore: bump solc in cli
Maddiaa0 fa7e903
fix: version
Maddiaa0 742f14e
Merge branch 'master' into md/shplemini-in-noir-output
Maddiaa0 6d3d492
Merge branch 'master' into md/shplemini-in-noir-output
Maddiaa0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,6 @@ | |
}, | ||
"dependencies": { | ||
"ethers": "^6.8.1", | ||
"solc": "^0.8.22" | ||
"solc": "^0.8.27" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,7 +119,7 @@ Barretenberg UltraHonk comes with the capability to verify proofs in Solidity, i | |
``` | ||
|
||
4. Generate Solidity verifier | ||
**WARNING:** Contract incomplete, do not use in production! | ||
**WARNING:** Contract unaudited, do not use in production! | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also incomplete cus we don't have support for aggregation yet :) |
||
|
||
```bash | ||
bb contract_ultra_honk -k ./target/vk -c $CRS_PATH -b ./target/hello_world.json -o ./target/Verifier.sol | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove