Remove quotes $artifacts_to_transpile in the for loop list of compile_then_transpile.sh
#8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With quotes on the `$artifacts_to_transpile` variable in the for loop, the loop list is treated as a single string, so it only runs once and fails with an error message like: ``` thread 'main' panicked at src/main.rs:31:29: Unable to read file: target/foo-Foo.json target/bar-Bar.json note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` because it tries to read a file named `target/foo-Foo.json\ntarget/bar-Bar.json` instead of handling `target/foo-Foo.json` and `target/bar-Bar.json` separately.
ludamad
added a commit
that referenced
this pull request
Oct 3, 2024
… for loop list of compile_then_transpile.sh (#8932) Thanks twt-- for #8845. Our policy is to redo typo changes to dissuade metric farming. This is an automated script. Co-authored-by: Tim Tickel <[email protected]> Co-authored-by: ludamad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remove quotes on
$artifacts_to_transpilevariable of the for loop list incompile_then-transpile.shso it can be treated as a list instead of a single value.When quotes are used here, transpilation of >1 artifact fails with an error like this:
This is because the transpiler tries to read a file named
target/foo-Foo.json\ntarget/bar-Bar.jsoninstead of handlingtarget/foo-Foo.jsonandtarget/bar-Bar.jsonseparately.