Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: makes ec addition opcode unsafe #8814

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

guipublic
Copy link
Contributor

This PR is the same as #8374, but with some added runtime checks as suggested by @zac-williamson.
#8374 was merged and then rollback because it caused issues with e2e tests.
We should not merge this one until this issue is fixed, but I need the PR as ready for review in order to have the CI to run.

The PR makes the ACIR opcode 'EC ADD' unsafe because the safety checks are now done on the Noir side in the stdlib's embedded curve operations.
It will allow Aztec protocol circuit to use directly the opcode when the 'safety' is already known (and implied by previous operations).

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Changes to circuit sizes

Generated at commit: 393fe779227f5114dd6044e3b1c5dda768b6f719, compared to commit: 1801f5b49fb3b153817a1596c6fd568f1c762fe5

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_reset_4_4_4_4_4_4_4_4_1 0 ➖ 0.00% -4 ✅ -0.01%
private_kernel_reset 0 ➖ 0.00% -64 ✅ -0.01%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_reset_4_4_4_4_4_4_4_4_1 34,897 (0) 0.00% 74,475 (-4) -0.01%
private_kernel_reset 91,933 (0) 0.00% 467,666 (-64) -0.01%

@guipublic guipublic added e2e-all CI: Enables this CI job. bench-all CI: Enables this CI job. labels Oct 1, 2024
@guipublic guipublic changed the title chore: makes ec addition opcode unsafe **DO NOT MERGE** chore: makes ec addition opcode unsafe Oct 3, 2024
@guipublic guipublic requested a review from TomAFrench October 4, 2024 16:29
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once CI is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bench-all CI: Enables this CI job. e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants