Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: misc example contracts use poseidon2 instead of pedersen #8800

Closed
wants to merge 1 commit into from

Conversation

dbanks12
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

dbanks12 commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dbanks12 and the rest of your teammates on Graphite Graphite

@dbanks12 dbanks12 changed the title chore: change shared mutables to use poseidon DO NOT MERGE - chore: change shared mutables to use poseidon Sep 25, 2024
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch from 048c01c to 1ebf0a0 Compare September 25, 2024 20:09
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Changes to public function bytecode sizes

Generated at commit: 52677b5f4ac40b4f68801fb139e6b9c712c080b4, compared to commit: 78fa676eda1c6b35fe843e72347a77f9f6d89fa4

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
NFT::public_dispatch -919 ✅ -2.34%
Test::public_dispatch -1,028 ✅ -3.13%
CardGame::public_dispatch -1,223 ✅ -4.34%
NFT::finalize_transfer_to_private -834 ✅ -14.93%
CardGame::on_cards_claimed -1,208 ✅ -16.16%
Test::create_l2_to_l1_message_public -838 ✅ -35.97%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
NFT::public_dispatch 38,292 (-919) -2.34%
Test::public_dispatch 31,822 (-1,028) -3.13%
CardGame::public_dispatch 26,933 (-1,223) -4.34%
NFT::finalize_transfer_to_private 4,751 (-834) -14.93%
CardGame::on_cards_claimed 6,267 (-1,208) -16.16%
Test::create_l2_to_l1_message_public 1,492 (-838) -35.97%

@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch 3 times, most recently from 6eaf58b to c22df98 Compare September 25, 2024 20:45
@dbanks12 dbanks12 force-pushed the 09-25-chore_use_Noir_implementation_of_pedersen_that_uses_MSM_instead_of_pedersen_BBs branch 2 times, most recently from a5e5935 to c36dba5 Compare September 25, 2024 21:09
@fcarreiro fcarreiro force-pushed the 09-25-chore_use_Noir_implementation_of_pedersen_that_uses_MSM_instead_of_pedersen_BBs branch from c36dba5 to 34ecb3e Compare September 26, 2024 09:58
@dbanks12 dbanks12 force-pushed the 09-25-chore_use_Noir_implementation_of_pedersen_that_uses_MSM_instead_of_pedersen_BBs branch from 34ecb3e to b8318e1 Compare September 27, 2024 16:37
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch from c22df98 to 116c205 Compare September 27, 2024 16:37
@dbanks12 dbanks12 force-pushed the 09-25-chore_use_Noir_implementation_of_pedersen_that_uses_MSM_instead_of_pedersen_BBs branch 2 times, most recently from 13a6955 to 5c74274 Compare September 27, 2024 16:38
Base automatically changed from 09-25-chore_use_Noir_implementation_of_pedersen_that_uses_MSM_instead_of_pedersen_BBs to master September 27, 2024 23:14
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch from 116c205 to f90bcb9 Compare October 1, 2024 19:29
@dbanks12 dbanks12 changed the base branch from master to db/shared-mutables-poseidon October 1, 2024 19:29
@dbanks12 dbanks12 changed the title DO NOT MERGE - chore: change shared mutables to use poseidon chore: misc example contracts use poseidon2 instead of pedersen Oct 1, 2024
@dbanks12 dbanks12 marked this pull request as draft October 1, 2024 19:30
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch 2 times, most recently from 41ba0f1 to f7cc093 Compare October 1, 2024 19:37
Base automatically changed from db/shared-mutables-poseidon to master October 1, 2024 20:05
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch from f7cc093 to 171cda0 Compare October 1, 2024 20:07
@dbanks12 dbanks12 marked this pull request as ready for review October 1, 2024 20:08
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch 2 times, most recently from 40ad36c to 1ed0472 Compare October 2, 2024 01:48
@dbanks12 dbanks12 force-pushed the db/poseidon-shared-mutables branch from 1ed0472 to f36f5bf Compare October 2, 2024 14:53
@dbanks12
Copy link
Collaborator Author

Not doing this for now. Doesn't buy us much.

@dbanks12 dbanks12 closed this Oct 22, 2024
@dbanks12 dbanks12 deleted the db/poseidon-shared-mutables branch November 21, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant