Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global variables in public inputs #861

Closed
wants to merge 3 commits into from
Closed

Conversation

LHerskind
Copy link
Contributor

Description

Addresses #826

  • Adds chainid and version into tx_context such that it becomes part of CombinedConstantData in the public inputs.
  • Adds chainid, version, blocknumber and timestamp to a new GlobalVariables in the RollupConstantData
  • In base rollup add checks that kernel chainid and version matches that from constants.

The values in global variables will be constrained from L1, separately, see #824 for more information on that.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@LHerskind LHerskind linked an issue Jun 15, 2023 that may be closed by this pull request
@LHerskind
Copy link
Contributor Author

Replaced by #882

@LHerskind LHerskind closed this Jun 19, 2023
@ludamad ludamad deleted the lh/826-global-variables branch August 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant