-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change the layout of arrays and vectors to be a single pointer #8448
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
81dc3d0
wip: change layout of arrays and vectors
sirasistant b23f7e3
fix slice ops
sirasistant ec5a946
update blackboxes
sirasistant 6627d93
various fixes
sirasistant 399c3ea
tons of fixes, remaning, foreign call slice returns
sirasistant b2ed449
fix: foreign call slice return
sirasistant 7f85ecc
remove store after increment rc
sirasistant eb7856f
Merge branch 'master' into arv/array_vector_layout
sirasistant dc06be8
refactor
sirasistant 97016e0
Merge branch 'master' into arv/array_vector_layout
sirasistant f8ff875
Merge branch 'master' into arv/array_vector_layout
sirasistant 656981c
fix stack leaks
sirasistant 3f36a2c
docs
sirasistant a64297f
noir fmt
sirasistant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, what was it before? we read the array start from the array address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, an array with nested arrays had:
Now an array with nested arrays has
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So previously the runtime needed to do a double dereference to get to the items. Now it's a single dereference and add one, to reach the items pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For vectors now it's also very similar: