fix: guesstimate gas for propose

[LHerskind]

Fixes #8444 by making a guesstimate on the amount of gas that we need. We need to do these gymnastics instead of the classic "gasEstimate" directly on the rollup contract as timestamps and simulations are not the best of friends.

[LHerskind]

• fix: guesstimate gas for propose #8445 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• public_db_access_time_ms (get-nullifier-index): 0.274 (+64%)
• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 48.8 (-70%)
• avm_simulation_time_ms (Token:mint_public): 309 (+581%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 388 (+17%)
• avm_simulation_bytecode_size_in_bytes (FeeJuice:_increase_public_balance): 1,808 (-21%)
• avm_simulation_bytecode_size_in_bytes (FeeJuice:set_portal): 1,846 (-29%)
• avm_simulation_bytecode_size_in_bytes (Token:constructor): 9,682 (-25%)
• avm_simulation_bytecode_size_in_bytes (FPC:constructor): 5,617 (-28%)
• avm_simulation_bytecode_size_in_bytes (FeeJuice:check_balance): 1,571 (-22%)
• avm_simulation_bytecode_size_in_bytes (Token:mint_public): 3,485 (-22%)
• avm_simulation_bytecode_size_in_bytes (Token:assert_minter_and_mint): 2,291 (-22%)
• avm_simulation_bytecode_size_in_bytes (AuthRegistry:set_authorized): 696 (-26%)
• avm_simulation_bytecode_size_in_bytes (FPC:prepare_fee): 2,695 (-32%)
• avm_simulation_bytecode_size_in_bytes (Token:transfer_public): 6,570 (-26%)
• avm_simulation_bytecode_size_in_bytes (FPC:pay_refund): 3,400 (-30%)
• avm_simulation_bytecode_size_in_bytes (Benchmarking:increment_balance): 2,208 (-30%)
• avm_simulation_bytecode_size_in_bytes (Token:_increase_public_balance): 1,818 (-20%)
• avm_simulation_bytecode_size_in_bytes (FPC:pay_refund_with_shielded_rebate): 3,400 (-30%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,735	1,541 (-1%)	713 (+3%)	775 (+1%)	775
proof_construction_time_sha256_30_ms	11,782 (+3%)	3,160 (+4%)	1,395 (+2%)	1,437 (+1%)	1,457
proof_construction_time_sha256_100_ms	44,050 (-3%)	11,689 (-1%)	5,374 (-6%)	5,812 (-2%)	5,355
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0 (-2%)	89.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,526	415	199	225 (-2%)	267 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,628	1,517 (+2%)	673 (+1%)	719 (-1%)	748 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,420 (+1%)	7,940 (+1%)	14,948
l1_rollup_calldata_gas	50,344	93,278	178,424
l1_rollup_execution_gas	843,477	1,577,307	3,362,510
l2_block_processing_time_in_ms	252 (-1%)	446 (-3%)	800 (-1%)
l2_block_building_time_in_ms	11,405 (-1%)	22,351 (-1%)	45,030
l2_block_rollup_simulation_time_in_ms	11,405 (-1%)	22,351 (-1%)	45,030
l2_block_public_tx_process_time_in_ms	9,725 (-1%)	20,667 (-1%)	43,317

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,418 (+3%)	4,279 (-2%)
node_database_size_in_bytes	14,233,840	18,219,248
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	70.7 (-6%)	375 (-1%)	21,027	44,933	N/A
private-kernel-inner	137 (-3%)	673	71,803	45,067	N/A
private-kernel-reset-tiny	289	669	64,669	44,922	N/A
private-kernel-tail	149 (-5%)	126	50,553	57,178	N/A
base-parity	5.54	N/A	160	96.0	N/A
root-parity	35.5	N/A	73,964	96.0	N/A
base-rollup	2,575	N/A	189,128	664	N/A
block-root-rollup	40.8 (-1%)	N/A	58,217	2,448	N/A
public-kernel-setup	83.6 (-2%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	97.0 (-1%)	N/A	114,251	79,670	N/A
public-kernel-tail	836	N/A	487,098	16,414	N/A
private-kernel-reset-small	267 (-1%)	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	782 (-1%)	591	449,631	1,825	N/A
public-kernel-teardown	83.1 (-1%)	N/A	114,697	79,670	N/A
merge-rollup	20.0	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	81,739 (-2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	340
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	419
FeeJuice:deploy	1,376	11,731	386 (-1%)
SchnorrAccount:constructor	1,312	11,731	60.0 (+1%)
SchnorrAccount:entrypoint	2,336	11,731	367 (-1%)
FeeJuice:claim	1,344	11,731	34.6 (-7%)
Token:privately_mint_private_note	1,280	11,731	70.9 (-3%)
FPC:fee_entrypoint_public	1,344	11,731	24.3 (-8%)
Token:transfer	1,312	11,731	207
Benchmarking:create_note	1,344	11,731	74.2 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.6
Token:unshield	1,376	11,731	487
FPC:fee_entrypoint_private	1,376	11,731	646 (-7%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 48.8 (-70%)	⚠️ 1,808 (-21%)
FeeJuice:set_portal	10.7 (-25%)	⚠️ 1,846 (-29%)
Token:constructor	77.5 (+7%)	⚠️ 9,682 (-25%)
FPC:constructor	56.6 (+19%)	⚠️ 5,617 (-28%)
FeeJuice:check_balance	36.5 (-6%)	⚠️ 1,571 (-22%)
Token:mint_public	⚠️ 309 (+581%)	⚠️ 3,485 (-22%)
Token:assert_minter_and_mint	⚠️ 388 (+17%)	⚠️ 2,291 (-22%)
AuthRegistry:set_authorized	36.5 (-23%)	⚠️ 696 (-26%)
FPC:prepare_fee	60.6 (-16%)	⚠️ 2,695 (-32%)
Token:transfer_public	19.8 (-8%)	⚠️ 6,570 (-26%)
FPC:pay_refund	39.7 (+8%)	⚠️ 3,400 (-30%)
Benchmarking:increment_balance	1,219	⚠️ 2,208 (-30%)
Token:_increase_public_balance	38.4 (+3%)	⚠️ 1,818 (-20%)
FPC:pay_refund_with_shielded_rebate	52.2	⚠️ 3,400 (-30%)

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	⚠️ 0.274 (+64%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.15	3.84 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112	0.108 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2	17.7	31.6 (+1%)	59.2 (-3%)	113 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.107	0.103	0.102 (+1%)	0.102 (-2%)	0.101 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2	25.4 (-3%)	43.2 (-3%)	82.4 (-1%)	160 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108	0.102 (-4%)	0.0991 (-8%)	0.102 (-1%)	0.102 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.2 (-2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,416	668,302

Transaction size based on fee payment method

| Metric | |
| - | |