fix: attestations are requested based on their proposal not just slot

[Maddiaa0]

Overview

Filters such that nodes request attestations based on more than just the slot number

fixes: #8028

[Maddiaa0]

• fix: attestations are requested based on their proposal not just slot #8442 👈
• feat: validators ensure transactions live in their p2p pool before attesting #8410
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_30_ms (16): 1,375 (-20%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 788 (-44%)
• avm_simulation_time_ms (FeeJuice:_increase_public_balance): 49.6 (-64%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 291 (+384%)
• avm_simulation_time_ms (Token:_increase_public_balance): 50.8 (+36%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,759	1,548	704	767 (+1%)	780
proof_construction_time_sha256_30_ms	11,460 (-1%)	3,061 (-1%)	⚠️ 1,375 (-20%)	1,430 (-9%)	1,464 (-5%)
proof_construction_time_sha256_100_ms	45,425	11,796	5,499 (-1%)	5,921	5,379 (-5%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	58.0	87.0
proof_construction_time_poseidon_hash_30_ms	1,530	417	199	222 (-1%)	269 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,653	1,504	669 (-1%)	730	752 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,612	8,260	15,524
l1_rollup_calldata_gas	52,768	97,552	186,932
l1_rollup_execution_gas	819,454	1,555,646	3,346,461
l2_block_processing_time_in_ms	260 (+3%)	447 (-1%)	832 (+4%)
l2_block_building_time_in_ms	9,343	18,374 (-1%)	36,697
l2_block_rollup_simulation_time_in_ms	9,343	18,374 (-1%)	36,696
l2_block_public_tx_process_time_in_ms	7,945	16,959 (-1%)	35,238

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,106 (-2%)	4,015 (-1%)
node_database_size_in_bytes	14,213,360	18,284,784
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	71.7 (-6%)	380 (+1%)	20,975	44,933	N/A
private-kernel-inner	140 (-1%)	683 (-1%)	71,787	45,067	N/A
private-kernel-reset-tiny	334 (+1%)	718 (+3%)	64,273	44,922	N/A
private-kernel-tail	153 (+1%)	132 (+1%)	50,551	57,178	N/A
base-parity	5.58 (+1%)	N/A	160	96.0	N/A
root-parity	35.2	N/A	73,964	96.0	N/A
base-rollup	2,135	N/A	189,128	664	N/A
block-root-rollup	41.4	N/A	58,217	2,448	N/A
public-kernel-setup	86.7 (+1%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	99.8	N/A	114,251	79,670	N/A
public-kernel-tail	583 (-1%)	N/A	487,098	16,414	N/A
private-kernel-reset-small	306 (+1%)	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	⚠️ 788 (-44%)	597 (-3%)	448,120	1,825	N/A
public-kernel-teardown	85.9	N/A	114,697	79,670	N/A
merge-rollup	19.9	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	104,149 (+1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	352 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.2
MultiCallEntrypoint:entrypoint	1,920	11,731	427 (+1%)
FeeJuice:deploy	1,376	11,731	399 (+2%)
SchnorrAccount:constructor	1,312	11,731	60.2
SchnorrAccount:entrypoint	2,336	11,731	369
FeeJuice:claim	1,344	11,731	37.0 (-1%)
Token:privately_mint_private_note	1,280	11,731	73.6 (+11%)
FPC:fee_entrypoint_public	1,344	11,731	28.4 (+17%)
Token:transfer	1,312	11,731	208
Benchmarking:create_note	1,344	11,731	74.7 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.5
Token:unshield	1,376	11,731	490
FPC:fee_entrypoint_private	1,376	11,731	654

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 49.6 (-64%)	1,188
FeeJuice:set_portal	10.6 (+20%)	1,170
Token:constructor	258 (+5%)	10,378
FPC:constructor	71.2 (+1%)	7,877
FeeJuice:check_balance	35.9 (+2%)	995
Token:mint_public	260 (+7%)	2,123
Token:assert_minter_and_mint	⚠️ 291 (+384%)	1,435
AuthRegistry:set_authorized	34.9 (-4%)	515
FPC:prepare_fee	85.2 (+4%)	1,588
Token:transfer_public	18.2 (+8%)	8,603
FPC:pay_refund	40.6 (+8%)	2,090
Benchmarking:increment_balance	1,001 (-1%)	1,516
Token:_increase_public_balance	⚠️ 50.8 (+36%)	1,159
FPC:pay_refund_with_shielded_rebate	49.3 (-1%)	2,090

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.166 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+2%)	3.86 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (+2%)	0.108 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.2	17.7	31.1 (+2%)	59.4 (-2%)	116 (+5%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.103	0.101 (+2%)	0.102 (-2%)	0.103 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3	26.3 (-1%)	44.3 (+2%)	82.8 (-1%)	165
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110 (+1%)	0.106 (-1%)	0.105 (+4%)	0.103 (-1%)	0.105 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.1	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,419	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

[github-actions]

Changes to public function bytecode sizes

Generated at commit: 276c68e08b439728c03a0249e64f6c2290c7f5c1, compared to commit: 3af238177ef273bec36c1faccad80ccc9cfed192

🧾 Summary (100% most significant diffs)

Program	Bytecode size in bytes (+/-)	%
Lending::public_dispatch	+1,956 ❌	+3.27%
CardGame::public_dispatch	+220 ❌	+0.99%
NFT::public_dispatch	+42 ❌	+0.16%
StatefulTest::public_dispatch	+14 ❌	+0.15%
InclusionProofs::public_dispatch	+7 ❌	+0.11%
TokenBridge::public_dispatch	+21 ❌	+0.06%
TokenBlacklist::public_dispatch	-35 ✅	-0.04%
AvmTest::public_dispatch	-49 ✅	-0.06%
Uniswap::public_dispatch	-28 ✅	-0.08%
Token::public_dispatch	-42 ✅	-0.08%
Auth::public_dispatch	-28 ✅	-0.17%
FPC::public_dispatch	-21 ✅	-0.17%

---

Full diff report 👇

Program	Bytecode size in bytes (+/-)	%
Lending::public_dispatch	61,837 (+1,956)	+3.27%
CardGame::public_dispatch	22,538 (+220)	+0.99%
NFT::public_dispatch	26,572 (+42)	+0.16%
StatefulTest::public_dispatch	9,648 (+14)	+0.15%
InclusionProofs::public_dispatch	6,132 (+7)	+0.11%
TokenBridge::public_dispatch	36,386 (+21)	+0.06%
TokenBlacklist::public_dispatch	93,584 (-35)	-0.04%
AvmTest::public_dispatch	82,961 (-49)	-0.06%
Uniswap::public_dispatch	36,521 (-28)	-0.08%
Token::public_dispatch	50,082 (-42)	-0.08%
Auth::public_dispatch	16,516 (-28)	-0.17%
FPC::public_dispatch	12,232 (-21)	-0.17%