chore: Do not clean up bb files on err

[spalladino]

Even if BB_SKIP_CLEANUP is not set, avoid deleting the tmp dir for bb if the operation fails, so we can retrieve those files later.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 43.3 (-41%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 68.9 (+73%)
• avm_simulation_time_ms (Token:transfer_public): 35.6 (+62%)
• avm_simulation_time_ms (Token:_increase_public_balance): 78.5 (+99%)
• l2_block_processing_time_in_ms (4): 404 (+58%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,797 (+1%)	1,569 (+1%)	714 (+1%)	768 (-1%)	767
proof_construction_time_sha256_30_ms	11,898	3,185	1,410	1,437	1,464
proof_construction_time_sha256_100_ms	45,777 (+1%)	12,004 (+1%)	5,468	5,358 (-1%)	5,382
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,537 (+1%)	423	203	225	274 (+2%)
proof_construction_time_poseidon_hash_100_ms	5,674 (+1%)	1,513	675	733 (-1%)	741

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,720	92,488	177,584
l1_rollup_execution_gas	1,294,383	2,042,119	3,869,254
l2_block_processing_time_in_ms	⚠️ 404 (+58%)	445 (-1%)	829 (+2%)
l2_block_building_time_in_ms	9,243	18,196	36,001 (-1%)
l2_block_rollup_simulation_time_in_ms	9,242	18,196	36,001 (-1%)
l2_block_public_tx_process_time_in_ms	7,822	16,649 (+1%)	34,427 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,010 (+2%)	3,840 (-4%)
node_database_size_in_bytes	12,738,640	16,814,160
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	101	393	21,846	44,858	N/A
private-kernel-inner	168	693	72,545	45,005	N/A
private-kernel-reset-tiny	509	1,198 (+1%)	69,614	44,844	N/A
private-kernel-tail	271 (+1%)	195 (+1%)	50,760	52,256	N/A
base-parity	5.53	N/A	160	96.0	N/A
root-parity	33.6 (+1%)	N/A	69,084	96.0	N/A
base-rollup	2,863	N/A	187,817	664	N/A
root-rollup	38.8	N/A	54,525	716	N/A
public-kernel-setup	100	N/A	103,760	71,222	N/A
public-kernel-app-logic	106	N/A	103,599	71,222	N/A
public-kernel-tail	571 (+1%)	N/A	409,190	16,414	N/A
private-kernel-reset-small	494 (+2%)	N/A	66,533	45,629	N/A
private-kernel-tail-to-public	1,489	708	507,554	1,697	N/A
public-kernel-teardown	95.0	N/A	104,005	71,222	N/A
merge-rollup	19.3 (+1%)	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	69,533 (+2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	345 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-2%)
MultiCallEntrypoint:entrypoint	1,920	11,731	458 (-1%)
FeeJuice:deploy	1,376	11,731	392 (+1%)
SchnorrAccount:constructor	1,312	11,731	169 (-1%)
SchnorrAccount:entrypoint	2,304	11,731	505 (-1%)
Token:privately_mint_private_note	1,280	11,731	213 (-4%)
FPC:fee_entrypoint_public	1,344	11,731	25.3 (-5%)
Token:transfer	1,312	11,731	406
Benchmarking:create_note	1,344	11,731	163 (-1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.6 (+1%)
Token:unshield	1,376	11,731	639 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	871 (+2%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	58.0 (+7%)	8,139
FeeJuice:set_portal	10.9 (+4%)	2,362
Token:constructor	87.1 (+3%)	31,107
FPC:constructor	53.1 (-3%)	22,380
FeeJuice:mint_public	38.2	6,150
Token:mint_public	⚠️ 43.3 (-41%)	11,720
Token:assert_minter_and_mint	⚠️ 68.9 (+73%)	8,028
AuthRegistry:set_authorized	46.6 (-1%)	4,537
FPC:prepare_fee	249 (-5%)	8,812
Token:transfer_public	⚠️ 35.6 (+62%)	47,374
FPC:pay_refund	59.9 (-5%)	12,114
Benchmarking:increment_balance	973 (+1%)	7,450
Token:_increase_public_balance	⚠️ 78.5 (+99%)	8,960
FPC:pay_refund_with_shielded_rebate	71.5 (+6%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.168 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.18 (-1%)	3.88 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (-1%)	0.109 (-3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5	17.5 (-5%)	30.6 (-1%)	58.7 (-2%)	112 (-3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110	0.102 (-5%)	0.0992 (-1%)	0.101 (-2%)	0.101 (-3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4	25.6 (-2%)	43.3	82.5 (-1%)	160 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109	0.103 (-2%)	0.105	0.102 (-1%)	0.101 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.3 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |